Color: Use SkColorSpacePrimaries

Color: Use SkColorSpacePrimaries

This is towards unifying SkColorSpace and gfx::ColorSpace.

BUG=634102
Review-Url: https://codereview.chromium.org/2643773006
Cr-Commit-Position: refs/heads/master@{#445229}
Committed: https://chromium.googlesource.com/chromium/src/+/f976090c94c127ad92dee96dda3600bd88891b90

[ccameron, 2017-01-20 02:21:42]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2017-01-20 02:21:42]

I'll also be adding a patch to populate a SkColorSpaceTransferFn.

[hubbe, 2017-01-20 20:15:27]

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform.cc
File ui/gfx/color_transform.cc (right):

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform....
ui/gfx/color_transform.cc:32: void GetPrimaries(ColorSpace::PrimaryID id,
Remove?

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform....
ui/gfx/color_transform.cc:163: primaries.toXYZD50(&matrix);
I assume that this doe the same chromatic adaptation that GetPrimaryMatrix()
used to do. I don't think we have enough tests to actually verify that right
now, so perhaps we can add another test?

[ccameron, 2017-01-20 23:24:29]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:25:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-20 23:26:16]

Updated.

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform.cc
File ui/gfx/color_transform.cc (right):

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform....
ui/gfx/color_transform.cc:32: void GetPrimaries(ColorSpace::PrimaryID id,
On 2017/01/20 20:15:27, hubbe wrote:
> Remove?

Done.

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform....
ui/gfx/color_transform.cc:163: primaries.toXYZD50(&matrix);
On 2017/01/20 20:15:27, hubbe wrote:
> I assume that this doe the same chromatic adaptation that GetPrimaryMatrix()
> used to do. I don't think we have enough tests to actually verify that right
> now, so perhaps we can add another test?

Yes, see the implementation at:
https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkColorSpace.c...

[hubbe, 2017-01-20 23:28:15]

LGTM

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform.cc
File ui/gfx/color_transform.cc (right):

https://codereview.chromium.org/2643773006/diff/20001/ui/gfx/color_transform....
ui/gfx/color_transform.cc:163: primaries.toXYZD50(&matrix);
On 2017/01/20 23:26:16, ccameron wrote:
> On 2017/01/20 20:15:27, hubbe wrote:
> > I assume that this doe the same chromatic adaptation that GetPrimaryMatrix()
> > used to do. I don't think we have enough tests to actually verify that right
> > now, so perhaps we can add another test?
> 
> Yes, see the implementation at:
>
https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkColorSpace.c...

looks good (but a test would have been even better)

[commit-bot: I haz the power, 2017-01-21 00:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:39:56]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-01-21 00:42:09]

Thanks!

[ccameron, 2017-01-21 00:42:14]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:42:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:47:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484959334286830,
"parent_rev": "f268555afd9369102dd7919fe7b52997f2b3996a", "commit_rev":
"f976090c94c127ad92dee96dda3600bd88891b90"}

[commit-bot: I haz the power, 2017-01-21 00:48:15]

Description was changed from

==========
Color: Use SkColorSpacePrimaries

This is towards unifying SkColorSpace and gfx::ColorSpace.

BUG=634102
==========

to

==========
Color: Use SkColorSpacePrimaries

This is towards unifying SkColorSpace and gfx::ColorSpace.

BUG=634102

Review-Url: https://codereview.chromium.org/2643773006
Cr-Commit-Position: refs/heads/master@{#445229}
Committed:
https://chromium.googlesource.com/chromium/src/+/f976090c94c127ad92dee96dda36...
==========

[commit-bot: I haz the power, 2017-01-21 00:48:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f976090c94c127ad92dee96dda36...