Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2643773002:
Restrict effective 2g blocking to cases where NQE says we are 2G-like. (Closed)
|
Created:
3 years, 11 months ago by Bryan McQuade Modified:
3 years, 11 months ago CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRestrict effective 2g blocking to cases where NQE says we are 2G-like.
The current impl triggers the effective 2g blocking if we're on either
2g or effective 2g.
This change simplifies things so we only trigger effective 2g blocking if
on effective 2g.
This makes experiments cleaner, as we can evaluate the impact of this
feature when NQE determines we're on 2G.
BUG=682260
Review-Url: https://codereview.chromium.org/2643773002
Cr-Commit-Position: refs/heads/master@{#444520}
Committed: https://chromium.googlesource.com/chromium/src/+/0b460c475f6f6fba74d9ba731398a1ce5328d4b0
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : cleanup #Patch Set 4 : rebase #Messages
Total messages: 27 (22 generated)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Restrict effective 2g blocking to cases where NQE says we are 2G-like. BUG= ========== to ========== Restrict effective 2g blocking to cases where NQE says we are 2G-like. BUG=682260 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Restrict effective 2g blocking to cases where NQE says we are 2G-like. BUG=682260 ========== to ========== Restrict effective 2g blocking to cases where NQE says we are 2G-like. The current impl triggers the effective 2g blocking if we're on either 2g or effective 2g. This change simplifies things so we only trigger effective 2g blocking if on effective 2g. This makes experiments cleaner, as we can evaluate the impact of this feature when NQE determines we're on 2G. BUG=682260 ==========
bmcquade@chromium.org changed reviewers: + japhet@chromium.org, jkarlin@chromium.org
PTAL, thanks!
lgtm!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bmcquade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484778662569210,
"parent_rev": "6cc8974e18028a1e18779c36318acfe5c069ec2c", "commit_rev":
"0b460c475f6f6fba74d9ba731398a1ce5328d4b0"}
Message was sent while issue was closed.
Description was changed from ========== Restrict effective 2g blocking to cases where NQE says we are 2G-like. The current impl triggers the effective 2g blocking if we're on either 2g or effective 2g. This change simplifies things so we only trigger effective 2g blocking if on effective 2g. This makes experiments cleaner, as we can evaluate the impact of this feature when NQE determines we're on 2G. BUG=682260 ========== to ========== Restrict effective 2g blocking to cases where NQE says we are 2G-like. The current impl triggers the effective 2g blocking if we're on either 2g or effective 2g. This change simplifies things so we only trigger effective 2g blocking if on effective 2g. This makes experiments cleaner, as we can evaluate the impact of this feature when NQE determines we're on 2G. BUG=682260 Review-Url: https://codereview.chromium.org/2643773002 Cr-Commit-Position: refs/heads/master@{#444520} Committed: https://chromium.googlesource.com/chromium/src/+/0b460c475f6f6fba74d9ba731398... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/0b460c475f6f6fba74d9ba731398... |
