Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2643763005: Remove obsolete methods from CRWRequestTrackerDelegate protocol. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete methods from CRWRequestTrackerDelegate protocol. The methods only had one non-test implementation that was either returning a constant or not doing anything (besides maybe calling NOTREACHED). BUG=585700 Review-Url: https://codereview.chromium.org/2643763005 Cr-Commit-Position: refs/heads/master@{#445025} Committed: https://chromium.googlesource.com/chromium/src/+/1a8ddf2e5a1ee482848599ee5b4d4faf8ac7ad19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -120 lines) Patch
M ios/web/net/crw_request_tracker_delegate.h View 2 chunks +0 lines, -21 lines 0 comments Download
M ios/web/net/request_tracker_impl.h View 4 chunks +0 lines, -14 lines 0 comments Download
M ios/web/net/request_tracker_impl.mm View 7 chunks +1 line, -60 lines 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 2 chunks +0 lines, -12 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look.
3 years, 11 months ago (2017-01-19 18:50:12 UTC) #4
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-19 18:52:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643763005/1
3 years, 11 months ago (2017-01-20 09:23:36 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 09:28:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a8ddf2e5a1ee482848599ee5b4d...

Powered by Google App Engine
This is Rietveld 408576698