Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2643743002: Mojify demuxers and allow running {Chunk/FFmpeg}Demuxer in a Utility Process (Closed)

Created:
3 years, 11 months ago by Julien Isorce
Modified:
3 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, creis+watch_chromium.org, apacible+watch_chromium.org, Aaron Boodman, posciak+watch_chromium.org, chfremer+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, alokp+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, darin (slow to review), viettrungluu+watch_chromium.org, erickung+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojify demuxers and allow running {Chunk/FFmpeg}Demuxer in a Utility Process Currently only useful when coupled with the mojo renderer service. I.e. when the output of demuxers is consumed in the separate process too. Indeed when used alone it is currently not implemented. Can be switch on with existing gn args: enable_mojo_media = true mojo_media_services = [ "demuxer", "renderer" ] mojo_media_host = "utility" Add SourceBuffer and change ChunkDemuxer to inherit from both Demuxer and SourceBuffer. Add DemuxerStreamProvider::Type::REMOTE. Add DemuxerStreamProvider::GetRemoteId. Add MojoMediaClient::CreateDemuxerFactory. Add MediaInterfaceProxy::CreateDemuxer. Add MojoRenderer::InitializeRendererFromRemoteId. Add DemuxerFactory and {Default,Mojo}DemuxerFactory. Add MojoDataSourceImpl / MojoDataSourceAdapter. Add MojoDataBufferWriter / MojoDataBufferReader. Add MojoDemuxer / MojoDemuxerService. Add MojoDemuxerSourceBuffer / MojoSourceBufferService. Add DemuxerManager / MojoDemuxerServiceContext. Mojify MediaTracks and Ranges<TimeDelta> BUG=682261 R=dalecurtis@chromium.org, sandersd@chromium.org, tguilbert@chromium.org, xhwang@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase and make sure to unbind mojom::DemuxerPtr on the bound thread during termination #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3550 lines, -160 lines) Patch
M content/browser/media/media_interface_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/media/media_interface_proxy.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M content/common/memory_messages.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/media_interface_provider.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 4 chunks +17 lines, -1 line 0 comments Download
M media/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/demuxer.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
A media/base/demuxer_factory.h View 1 chunk +49 lines, -0 lines 0 comments Download
A media/base/demuxer_factory.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/base/ipc/media_param_traits_macros.h View 1 4 chunks +16 lines, -0 lines 0 comments Download
M media/base/media_resource.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M media/base/media_resource.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
A media/base/source_buffer.h View 1 1 chunk +77 lines, -0 lines 0 comments Download
A media/base/source_buffer.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 6 chunks +7 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 15 chunks +52 lines, -51 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M media/blink/webmediasource_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/blink/webmediasource_impl.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M media/blink/websourcebuffer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/blink/websourcebuffer_impl.cc View 9 chunks +26 lines, -25 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 6 chunks +31 lines, -32 lines 0 comments Download
A media/filters/default_demuxer_factory.h View 1 chunk +42 lines, -0 lines 0 comments Download
A media/filters/default_demuxer_factory.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M media/mojo/clients/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_data_source_impl.h View 1 chunk +65 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_data_source_impl.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_demuxer.h View 1 1 chunk +99 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_demuxer.cc View 1 1 chunk +236 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_demuxer_factory.h View 1 chunk +49 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_demuxer_factory.cc View 1 1 chunk +70 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_demuxer_source_buffer.h View 1 1 chunk +116 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_demuxer_source_buffer.cc View 1 1 chunk +303 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 1 3 chunks +50 lines, -6 lines 0 comments Download
M media/mojo/clients/mojo_renderer_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M media/mojo/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/common/media_type_converters.h View 2 chunks +41 lines, -0 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 2 chunks +127 lines, -0 lines 0 comments Download
A media/mojo/common/mojo_data_buffer_converter.h View 1 chunk +96 lines, -0 lines 0 comments Download
A media/mojo/common/mojo_data_buffer_converter.cc View 1 1 chunk +269 lines, -0 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A media/mojo/interfaces/data_source.mojom View 1 chunk +26 lines, -0 lines 0 comments Download
A media/mojo/interfaces/demuxer.mojom View 1 chunk +55 lines, -0 lines 0 comments Download
A media/mojo/interfaces/demuxer.typemap View 1 chunk +16 lines, -0 lines 0 comments Download
M media/mojo/interfaces/interface_factory.mojom View 1 chunk +8 lines, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 3 chunks +49 lines, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.typemap View 1 2 chunks +4 lines, -0 lines 0 comments Download
M media/mojo/interfaces/renderer.mojom View 1 1 chunk +1 line, -0 lines 0 comments Download
A media/mojo/interfaces/source_buffer.mojom View 1 1 chunk +74 lines, -0 lines 0 comments Download
A media/mojo/interfaces/source_buffer.typemap View 1 chunk +17 lines, -0 lines 0 comments Download
M media/mojo/interfaces/typemaps.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 3 chunks +10 lines, -0 lines 0 comments Download
M media/mojo/services/interface_factory_impl.h View 5 chunks +20 lines, -1 line 0 comments Download
M media/mojo/services/interface_factory_impl.cc View 5 chunks +40 lines, -1 line 0 comments Download
M media/mojo/services/media_resource_shim.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/services/media_service_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
A media/mojo/services/mojo_data_source_adapter.h View 1 chunk +76 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_data_source_adapter.cc View 1 chunk +136 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_demuxer_service.h View 1 chunk +94 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_demuxer_service.cc View 1 1 chunk +270 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_demuxer_service_context.h View 1 chunk +53 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_demuxer_service_context.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 3 chunks +6 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_media_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 6 chunks +15 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 8 chunks +53 lines, -9 lines 0 comments Download
A media/mojo/services/mojo_source_buffer_service.h View 1 1 chunk +103 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_source_buffer_service.cc View 1 1 chunk +217 lines, -0 lines 0 comments Download
M media/mojo/services/utility_mojo_media_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/utility_mojo_media_client.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Julien Isorce
Sorry Patch Set 2 contains a rebase and a fix. The fix part is: 144 ...
3 years, 10 months ago (2017-02-07 16:20:34 UTC) #2
Julien Isorce
3 years, 3 months ago (2017-09-13 12:25:07 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698