Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: media/base/pipeline_impl.cc

Issue 2643743002: Mojify demuxers and allow running {Chunk/FFmpeg}Demuxer in a Utility Process (Closed)
Patch Set: Rebase and make sure to unbind mojom::DemuxerPtr on the bound thread during termination Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_resource.cc ('k') | media/base/source_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl.cc
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index 0ec81f9e7ca815c345531ba3f35ce1779b93d393..40fe78b5a98244eb43455aecd70220c434725dcd 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -859,6 +859,14 @@ void PipelineImpl::RendererWrapper::InitializeRenderer(
DCHECK(media_task_runner_->BelongsToCurrentThread());
switch (demuxer_->GetType()) {
+ case MediaResource::Type::REMOTE:
+ if (demuxer_->GetRemoteId() == MediaResource::kInvalidRemoteId) {
+ DVLOG(1) << "Error: demuxer does not have a valid remote id.";
+ done_cb.Run(PIPELINE_ERROR_COULD_NOT_RENDER);
+ return;
+ }
+ break;
+
case MediaResource::Type::STREAM:
if (!demuxer_->GetStream(DemuxerStream::AUDIO) &&
!demuxer_->GetStream(DemuxerStream::VIDEO)) {
@@ -922,6 +930,7 @@ void PipelineImpl::RendererWrapper::ReportMetadata() {
}
break;
+ case MediaResource::Type::REMOTE:
case MediaResource::Type::URL:
// We don't know if the MediaPlayerRender has Audio/Video until we start
// playing. Conservatively assume that they do.
« no previous file with comments | « media/base/media_resource.cc ('k') | media/base/source_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698