Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2643733002: Allow to use {FFmpeg/Vpx}VideoDecoder from a UtilityProcess (Closed)

Created:
3 years, 11 months ago by Julien Isorce
Modified:
3 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow to use {FFmpeg/Vpx}VideoDecoder from a UtilityProcess Can be switch on with existing gn args: enable_mojo_media = true mojo_media_services = [ "video_decoder" ] mojo_media_host = "utility" Add UtilityMojoMediaClient. Add VideoFrameProvider interface. Add {Default/Mojo}VideoFrameProvider implementations. BUG=682252 R=dalecurtis@chromium.org, sandersd@chromium.org, tguilbert@chromium.org, xhwang@chromium.org

Patch Set 1 #

Patch Set 2 : A few fixes after first run of bots #

Patch Set 3 : Fix build #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -14 lines) Patch
M content/utility/utility_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/video_frame_pool.h View 4 chunks +6 lines, -1 line 0 comments Download
M media/base/video_frame_pool.cc View 7 chunks +23 lines, -12 lines 0 comments Download
A media/base/video_frame_provider.h View 1 chunk +35 lines, -0 lines 0 comments Download
A media/base/video_frame_provider.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M media/mojo/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/common/mojo_shared_buffer_video_frame.h View 1 chunk +9 lines, -0 lines 0 comments Download
M media/mojo/common/mojo_shared_buffer_video_frame.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A media/mojo/common/mojo_video_frame_provider.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A media/mojo/common/mojo_video_frame_provider.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/media_service_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/services/media_service_factory.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A media/mojo/services/utility_mojo_media_client.h View 1 chunk +37 lines, -0 lines 0 comments Download
A media/mojo/services/utility_mojo_media_client.cc View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
A media/video/default_video_frame_provider.h View 1 chunk +33 lines, -0 lines 0 comments Download
A media/video/default_video_frame_provider.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (13 generated)
Julien Isorce
3 years, 3 months ago (2017-09-13 12:22:00 UTC) #14
On 2017/01/19 15:40:28, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Moved to gerrit:
https://chromium-review.googlesource.com/c/chromium/src/+/664797

Powered by Google App Engine
This is Rietveld 408576698