Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2643713003: Allow to use the DefaultRendererFactory from a Utility Process (Closed)

Created:
3 years, 11 months ago by Julien Isorce
Modified:
3 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, apacible+watch_chromium.org, alokp+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, darin (slow to review), viettrungluu+watch_chromium.org, erickung+watch_chromium.org, o1ka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow to use the DefaultRendererFactory from a Utility Process Can be switch on with existing gn args: enable_mojo_media = true mojo_media_services = [ "renderer" ] mojo_media_host = "utility" This CLs allow to run the whole chromium media pipeline, except demuxers, in a separate utility process instead of the renderer process. Add UtilityMojoMediaClient::CreateRendererFactory. Add UtilityMojoMediaClient::CreateVideoRendererSink. Add MojoVideoRendererSinkImpl/Adapter and video_renderer_sink.mojom. Add VideoFrameProviderFactory interface. Add {Default/Mojo}VideoFrameProviderFactory implementations. The remote audio is for now just a NullAudioSink. It will be done in a separate CL and very similar as video_renderer_sink.mojom design. BUG=682252 R=dalecurtis@chromium.org, sandersd@chromium.org, tguilbert@chromium.org, xhwang@chromium.org

Patch Set 1 #

Patch Set 2 : Use AssociatedPtr and ensure to unbind from the compositor thread #

Patch Set 3 : recall git cl upstream #

Patch Set 4 : recall git cl upstream #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -23 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/utility_service_factory.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/utility/utility_service_factory.cc View 1 2 3 4 3 chunks +7 lines, -2 lines 0 comments Download
M media/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A media/base/video_frame_provider_factory.h View 1 chunk +30 lines, -0 lines 0 comments Download
A media/base/video_frame_provider_factory.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/clients/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer.h View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 1 2 3 4 6 chunks +26 lines, -4 lines 0 comments Download
A media/mojo/clients/mojo_video_renderer_sink_impl.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_video_renderer_sink_impl.cc View 1 1 chunk +105 lines, -0 lines 0 comments Download
M media/mojo/common/BUILD.gn View 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A media/mojo/common/mojo_video_frame_provider_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
A media/mojo/common/mojo_video_frame_provider_factory.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/renderer.mojom View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A media/mojo/interfaces/video_renderer_sink.mojom View 1 1 chunk +25 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/media_service_factory.h View 2 3 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/media_service_factory.cc View 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M media/mojo/services/media_service_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_video_renderer_sink_adapter.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_video_renderer_sink_adapter.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
M media/mojo/services/test_mojo_media_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/utility_mojo_media_client.h View 2 3 2 chunks +12 lines, -1 line 0 comments Download
M media/mojo/services/utility_mojo_media_client.cc View 1 2 3 4 chunks +30 lines, -1 line 0 comments Download
M media/renderers/default_renderer_factory.h View 3 chunks +8 lines, -3 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 2 3 3 chunks +18 lines, -4 lines 0 comments Download
A media/video/default_video_frame_provider_factory.h View 1 chunk +26 lines, -0 lines 0 comments Download
A media/video/default_video_frame_provider_factory.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (1 generated)
Julien Isorce
3 years, 3 months ago (2017-09-13 12:23:16 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698