Add a fake cursor (blinking UIView) to the widget extension.

Add a fake cursor (blinking UIView) to the widget extension.

BUG=none

Review-Url: https://codereview.chromium.org/2643723006
Cr-Commit-Position: refs/heads/master@{#444746}
Committed: https://chromium.googlesource.com/chromium/src/+/65cb0750b08c502c44d7b9efff7bc7e9e3309d7a

[lody, 2017-01-19 10:23:02]

lod@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[lody, 2017-01-19 10:23:02]

please review, thanks

[Olivier, 2017-01-19 10:33:07]

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
File ios/chrome/widget_extension/widget_view.mm (right):

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view.mm:29: - (void)addCursor {
declare method and add comment.
Document that it sets the property of the class.

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view.mm:30: UIView* cursor = [[UIView alloc]
initWithFrame:CGRectZero];
Is the cursor added directly in the widget view?
Should there be a fake input box around the fake cursor?

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view.mm:33: [self addSubview:_cursor];
cursor or self.cursor

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
File ios/chrome/widget_extension/widget_view_controller.mm (right):

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view_controller.mm:15: @interface
WidgetViewController ()<NCWidgetProviding>
Do you use anything from this protocol?

[lody, 2017-01-19 13:17:55]

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
File ios/chrome/widget_extension/widget_view.mm (right):

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view.mm:29: - (void)addCursor {
On 2017/01/19 10:33:07, Olivier Robin wrote:
> declare method and add comment.
> Document that it sets the property of the class.

Done.

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view.mm:30: UIView* cursor = [[UIView alloc]
initWithFrame:CGRectZero];
On 2017/01/19 10:33:07, Olivier Robin wrote:
> Is the cursor added directly in the widget view?
> Should there be a fake input box around the fake cursor?

Some of the current mocks say yes, some say no. I stuck with no for now (the
screenshot issue continues to exist with the animated cursor, so this is the
minimum necessary to see it happen.)

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view.mm:33: [self addSubview:_cursor];
On 2017/01/19 10:33:07, Olivier Robin wrote:
> cursor or self.cursor

Done.

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
File ios/chrome/widget_extension/widget_view_controller.mm (right):

https://codereview.chromium.org/2643723006/diff/1/ios/chrome/widget_extension...
ios/chrome/widget_extension/widget_view_controller.mm:15: @interface
WidgetViewController ()<NCWidgetProviding>
On 2017/01/19 10:33:07, Olivier Robin wrote:
> Do you use anything from this protocol?

hmm, not yet. I was experimenting. I'll remove it for this CL.

[Olivier, 2017-01-19 14:55:11]

LGTM one suggestion.

https://codereview.chromium.org/2643723006/diff/20001/ios/chrome/widget_exten...
File ios/chrome/widget_extension/widget_view.mm (right):

https://codereview.chromium.org/2643723006/diff/20001/ios/chrome/widget_exten...
ios/chrome/widget_extension/widget_view.mm:42: constant:40],
nit: create constants for these.

[lody, 2017-01-19 15:49:17]

The CQ bit was checked by lod@chromium.org

[lody, 2017-01-19 15:49:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2643723006/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2017-01-19 15:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:02:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484840957544730,
"parent_rev": "8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3", "commit_rev":
"65cb0750b08c502c44d7b9efff7bc7e9e3309d7a"}

[commit-bot: I haz the power, 2017-01-19 16:06:03]

Description was changed from

==========
Add a fake cursor (blinking UIView) to the widget extension.

BUG=none
==========

to

==========
Add a fake cursor (blinking UIView) to the widget extension.

BUG=none

Review-Url: https://codereview.chromium.org/2643723006
Cr-Commit-Position: refs/heads/master@{#444746}
Committed:
https://chromium.googlesource.com/chromium/src/+/65cb0750b08c502c44d7b9efff7b...
==========

[commit-bot: I haz the power, 2017-01-19 16:06:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/65cb0750b08c502c44d7b9efff7b...