tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index eef0a376034b7a9d51553b265a49c94b159950ff..05fc8024731c81415145322ce306d04eca7b9f48 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10071,6 +10071,34 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DesktopIOSPromotion.IOSSigninReason"
+    enum="DesktopIOSPromotionEntryPoint">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] For users who sign-in on Chrome for iOS, log the type of the desktop
+    iOS promotions that was shown to the user. Only recorded if the user has
+    seen at least one desktop iOS promotion in the last 7 days and is signing
+    into chrome on iOS. The last promotion entry point that sent an SMS (if any)
+    is logged as DesktopIOSPromot.SMSSent.IOSSigninReason; all other promotions
+    that the user has seen are logged as
+    DesktopIOSPromotion.NoSMS.IOSSigninReason.
+  </summary>
+</histogram>
+
+<histogram name="DesktopIOSPromotion.SMSToSigninTime" units="hours">
+  <owner>mrefaat@chromium.org</owner>
+  <summary>
+    [IOS] The difference between the client time of triggering the SMS action on
+    a specific entry point promotion on desktop and client time of signing in
+    Chrome iOS app. This will only be logged if at least one promotion was shown
+    to the user on the last 7 days and if at least one SMS was sent. If multiple

[Mark P, 2017/01/28 05:00:53]

"to the user on the last 7 days and if at least one SMS was sent"
implies that it's true if at least one promotion was shown in the last seven
days and one SMS was sent (at any point)

Is that right?

If so, please add "(at any time)" to the end of the sentence.
If not, please replace "and if at least one SMS was sent" with "that sent an
SMS".

[mrefaat, 2017/01/30 16:32:23]

That's right - added (at any time)

+    SMSs were sent, it uses the time from the most recently sent one. If the
+    value is negative due to bad clock on one of the clients it will be logged
+    as 0. CompletionTime will be prefixed by the entry point promotion name that
+    was responsible for the SMS sending.
+  </summary>
+</histogram>
+
 <histogram name="DevTools.ActionTaken" enum="DevToolsAction">
   <owner>sergeyv@chromium.org</owner>
   <owner>vsevik@chromium.org</owner>
@@ -83526,6 +83554,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="12" label="Tab capturer created without audio capturer."/>
 </enum>
 
+<enum name="DesktopIOSPromotionEntryPoint" type="int">
+  <int value="1" label="Save Passwords new bubble."/>
+  <int value="2" label="Bookmarks new bubble."/>
+  <int value="3" label="Bookmarks existing bubble."/>
+  <int value="4" label="HistoryPage."/>
+</enum>
+
 <enum name="DesktopSearchRedirectionInfobarCloseAction" type="int">
   <int value="0" label="Clicked the 'Manage search settings' link"/>
   <int value="1" label="Clicked the dismiss button"/>
@@ -112247,6 +112282,22 @@ value.
       name="Prerender.SimulatedLocalBrowsingPLT_PrerenderNoUse"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DesktopIOSEntryPoints" separator="."
+    ordering="prefix">
+  <suffix name="SavePasswordsNewBubble"/>
+  <suffix name="BookmarksNewBubble"/>
+  <suffix name="BookmarksExistingBubble"/>
+  <suffix name="HistoryPage"/>
+  <affected-histogram name="DesktopIOSPromotion.SMSToSigninTime"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="DesktopIOSPromotionSMSSent" separator="."
+    ordering="prefix">
+  <suffix name="SMSSent" label="SMS sent from the promotion."/>
+  <suffix name="NoSMS" label="No SMS was sent from the promotion."/>
+  <affected-histogram name="DesktopIOSPromotion.IOSSigninReason"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DiskUsagePerUserCount" separator=".">
   <suffix name="1User" label="Only 1 user exists on device."/>
   <suffix name="2Users" label="2 users exist on device."/>