Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: ios/chrome/browser/pref_names.cc

Issue 2643723004: Add Desktop iOS promotion logging to chrome ios app. (Closed)
Patch Set: change histogram name Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/pref_names.cc
diff --git a/ios/chrome/browser/pref_names.cc b/ios/chrome/browser/pref_names.cc
index 0f75891881a2994a01b2fc19aac88864a4f13d39..5fccd808e994612005d6cbf21c10da80aff25f9e 100644
--- a/ios/chrome/browser/pref_names.cc
+++ b/ios/chrome/browser/pref_names.cc
@@ -139,4 +139,22 @@ const char kOmniboxGeolocationLastAuthorizationAlertVersion[] =
const char kRateThisAppDialogLastShownTime[] =
"ios.ratethisapp.dialog_last_shown_time";
+// Integer which indicates which desktop ios promotion initiated sending the SMS
sdefresne 2017/01/30 15:47:19 ios -> iOS What does "desktop ios" mean? I don't
mrefaat 2017/01/30 16:32:23 Acknowledged.
+// to the user.
+const char kDesktopIOSPromotionSMSEntryPoint[] =
+ "ios.desktop_ios_promo_sms_entrypoint";
+
+// Integer Which indicates which desktop ios promotions did the user see.
sdefresne 2017/01/30 15:47:19 ditto Maybe // Indexes of the entry points prese
mrefaat 2017/01/30 16:32:23 Acknowledged.
+const char kDesktopIOSPromotionShownEntryPoints[] =
+ "ios.desktop_ios_promo_shown_entrypoints";
+
+// Last desktop ios promotion impression (If SMS was sent it's the time of
sdefresne 2017/01/30 15:47:19 ditto Maybe // Timestamp of the last "desktop to
mrefaat 2017/01/30 16:32:23 Acknowledged.
+// sending the SMS).
+const char kDesktopIOSPromotionLastImpression[] =
+ "ios.desktop_ios_promo_last_impression";
+
+// True if the user see the promotion, get sms, install and sign into
sdefresne 2017/01/30 15:47:19 ditto Maybe // True if the promotion was success
mrefaat 2017/01/30 16:32:23 Acknowledged.
+// chrome ios.
+const char kDesktopIOSPromotionDone[] = "ios.desktop_ios_promo_done";
+
} // namespace prefs

Powered by Google App Engine
This is Rietveld 408576698