Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 2643703002: Percent-width blocks cannot form a re-layout boundary. (Closed)

Created:
3 years, 11 months ago by mstensho (USE GERRIT)
Modified:
3 years, 11 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Percent-width blocks cannot form a re-layout boundary. A block with non-visible overflow can only form a re-layout boundary if both width and height are fixed. The block may be inside a shrink-to-fit container (there's no cheap and reliable way to detect that), so that changes inside it may affect its width. BUG=681657 Review-Url: https://codereview.chromium.org/2643703002 Cr-Commit-Position: refs/heads/master@{#444467} Committed: https://chromium.googlesource.com/chromium/src/+/da179e152dff0ab3e3dabc72299bd4fb586881c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-intrinsic-dimensions/resize-inside-percent-width-overflow-hidden.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 11 months ago (2017-01-18 12:24:53 UTC) #6
cbiesinger
lgtm
3 years, 11 months ago (2017-01-18 19:59:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643703002/1
3 years, 11 months ago (2017-01-18 20:27:25 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 20:40:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da179e152dff0ab3e3dabc72299b...

Powered by Google App Engine
This is Rietveld 408576698