Fix language/bad_constructor_test in dartk and analyzer.

pkg/analyzer/lib/src/generated/error_verifier.dart

Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index 1b99f57aaca59e32d6d22f80900cde5fe13cba4e..d15dae76cdef88873906051bf13cbd5ee10f381b 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -2706,8 +2706,8 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
     if (constructorName != null &&
         constructorElement != null &&
         !constructorName.isSynthetic) {
-      if (classElement.getField(name) != null) {
-        // fields
+      FieldElement field = classElement.getField(name);
+      if (field != null && field.getter != null) {

[scheglov, 2017/01/18 17:11:52]

Could you add a couple of unit tests to analyzer?

To non_error_resolver_test.dart/NonErrorResolverTest:

  test_conflictingConstructorNameAndMember_setter() async {
    Source source = addSource(r'''
class A {
  A.x() {}
  set x(_) {}
}''');
    await computeAnalysisResult(source);
    assertNoErrors(source);
    verify([source]);
  }


To compile_time_error_code_test.dart/CompileTimeErrorCodeTest:

  test_conflictingConstructorNameAndMember_getter() async {
    Source source = addSource(r'''
class A {
  int get x => 42;
  A.x() {}
}''');
    await computeAnalysisResult(source);
    assertErrors(
        source, [CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_FIELD]);
    verify([source]);
  }

[asgerf, 2017/01/18 18:18:34]

Absolutely! Thanks for writing them.

         _errorReporter.reportErrorForNode(
             CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_FIELD,
             constructor,