WTF: Support std::initializer_list in HashMap.

WTF: Support std::initializer_list in HashMap.

BUG=610931
Review-Url: https://codereview.chromium.org/2643663002
Cr-Commit-Position: refs/heads/master@{#444671}
Committed: https://chromium.googlesource.com/chromium/src/+/0cf301238f4cc06710e045c0dc4fcfa7a6fd5bf0

[Yuta Kitamura, 2017-01-18 07:47:46]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 07:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuta Kitamura, 2017-01-18 08:20:09]

Description was changed from

==========
WTF: Support std::initializer_list in HashMap.

BUG=610931
==========

to

==========
WTF: Support std::initializer_list in HashMap.

BUG=610931
==========

[Yuta Kitamura, 2017-01-18 08:20:09]

yutak@chromium.org changed reviewers:
+ tzik@chromium.org

[Yuta Kitamura, 2017-01-18 08:20:16]

PTAL?

[commit-bot: I haz the power, 2017-01-18 10:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 10:46:44]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-01-18 13:36:41]

looks good!

https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashMap.h (right):

https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashMap.h:353: add(element.key, element.value);
Can we std::move() them?

[Yuta Kitamura, 2017-01-19 06:07:04]

https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashMap.h (right):

https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashMap.h:353: add(element.key, element.value);
On 2017/01/18 13:36:40, tzik wrote:
> Can we std::move() them?

No, because std::initializer_list<T>::reference is const T&;
the type of |element| can't be ValueType&&.

[Yuta Kitamura, 2017-01-19 06:08:08]

https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashMap.h (right):

https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashMap.h:353: add(element.key, element.value);
On 2017/01/19 06:07:04, Yuta Kitamura wrote:
> the type of |element| can't be ValueType&&.

typo: ValueType&& -> ValueType&.

[tzik, 2017-01-19 06:34:04]

lgtm

[Yuta Kitamura, 2017-01-19 07:15:20]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 07:20:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484810120633920, "parent_rev":
"7d14431e53bbbb8a6bb4b42bc3093c9e0e07c8ae", "commit_rev":
"0cf301238f4cc06710e045c0dc4fcfa7a6fd5bf0"}

[commit-bot: I haz the power, 2017-01-19 07:20:38]

Description was changed from

==========
WTF: Support std::initializer_list in HashMap.

BUG=610931
==========

to

==========
WTF: Support std::initializer_list in HashMap.

BUG=610931

Review-Url: https://codereview.chromium.org/2643663002
Cr-Commit-Position: refs/heads/master@{#444671}
Committed:
https://chromium.googlesource.com/chromium/src/+/0cf301238f4cc06710e045c0dc4f...
==========

[commit-bot: I haz the power, 2017-01-19 07:20:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cf301238f4cc06710e045c0dc4f...