Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2643663002: WTF: Support std::initializer_list in HashMap. (Closed)

Created:
3 years, 11 months ago by Yuta Kitamura
Modified:
3 years, 11 months ago
Reviewers:
tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF: Support std::initializer_list in HashMap. BUG=610931 Review-Url: https://codereview.chromium.org/2643663002 Cr-Commit-Position: refs/heads/master@{#444671} Committed: https://chromium.googlesource.com/chromium/src/+/0cf301238f4cc06710e045c0dc4fcfa7a6fd5bf0

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/HashMap.h View 3 chunks +35 lines, -0 lines 3 comments Download
M third_party/WebKit/Source/wtf/HashMapTest.cpp View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Yuta Kitamura
PTAL?
3 years, 11 months ago (2017-01-18 08:20:16 UTC) #5
tzik
looks good! https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/wtf/HashMap.h File third_party/WebKit/Source/wtf/HashMap.h (right): https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/wtf/HashMap.h#newcode353 third_party/WebKit/Source/wtf/HashMap.h:353: add(element.key, element.value); Can we std::move() them?
3 years, 11 months ago (2017-01-18 13:36:41 UTC) #8
Yuta Kitamura
https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/wtf/HashMap.h File third_party/WebKit/Source/wtf/HashMap.h (right): https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/wtf/HashMap.h#newcode353 third_party/WebKit/Source/wtf/HashMap.h:353: add(element.key, element.value); On 2017/01/18 13:36:40, tzik wrote: > Can ...
3 years, 11 months ago (2017-01-19 06:07:04 UTC) #9
Yuta Kitamura
https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/wtf/HashMap.h File third_party/WebKit/Source/wtf/HashMap.h (right): https://codereview.chromium.org/2643663002/diff/1/third_party/WebKit/Source/wtf/HashMap.h#newcode353 third_party/WebKit/Source/wtf/HashMap.h:353: add(element.key, element.value); On 2017/01/19 06:07:04, Yuta Kitamura wrote: > ...
3 years, 11 months ago (2017-01-19 06:08:08 UTC) #10
tzik
lgtm
3 years, 11 months ago (2017-01-19 06:34:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643663002/1
3 years, 11 months ago (2017-01-19 07:15:38 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 07:20:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cf301238f4cc06710e045c0dc4f...

Powered by Google App Engine
This is Rietveld 408576698