Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2643643011: [Sync] Integ tests can't compare progress markers during configuration. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
skym, pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Integ tests can't compare progress markers during configuration. GetActiveDataTypes() returns an empty set during configuration, so ProgressMarkersMatch could return a false positive if either service was in the middle of configuration during a check. BUG=637023 Review-Url: https://codereview.chromium.org/2643643011 Cr-Commit-Position: refs/heads/master@{#445430} Committed: https://chromium.googlesource.com/chromium/src/+/c4706b070fab0bee61323c702cb91e3405070cc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/sync/test/integration/quiesce_status_change_checker.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
maxbogue
Pavel, PTAL!
3 years, 11 months ago (2017-01-20 19:44:00 UTC) #4
skym
lgtm
3 years, 11 months ago (2017-01-20 20:06:58 UTC) #8
pavely
lgtm
3 years, 11 months ago (2017-01-23 17:59:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643643011/1
3 years, 11 months ago (2017-01-23 18:16:10 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 19:18:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4706b070fab0bee61323c702cb9...

Powered by Google App Engine
This is Rietveld 408576698