Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2643643010: Remove unused RenderWidgetHostImpl::SetEditCommandsForNextKeyEvent (Closed)

Created:
3 years, 11 months ago by foolip
Modified:
3 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused RenderWidgetHostImpl::SetEditCommandsForNextKeyEvent It was introduced in https://codereview.chromium.org/7972006 but not used then or now. BUG=87335 Review-Url: https://codereview.chromium.org/2643643010 Cr-Commit-Position: refs/heads/master@{#445667} Committed: https://chromium.googlesource.com/chromium/src/+/85f0afc642c1ce8bcfe452d24400f8d5c8281758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
foolip
PTAL, needs to be landed after https://codereview.chromium.org/2644843004/ to not make the EditCommand forward declaration temporarily ...
3 years, 11 months ago (2017-01-20 10:26:55 UTC) #4
sadrul
lgtm
3 years, 11 months ago (2017-01-23 18:13:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643643010/1
3 years, 11 months ago (2017-01-24 05:34:19 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 06:41:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85f0afc642c1ce8bcfe452d24400...

Powered by Google App Engine
This is Rietveld 408576698