[WebPayments] Adding something resembling Shipping Address list

[WebPayments] Adding something resembling Shipping Address list

BUG=679449
Review-Url: https://codereview.chromium.org/2643643006
Cr-Commit-Position: refs/heads/master@{#446343}
Committed: https://chromium.googlesource.com/chromium/src/+/36405629cb79a21a8a395592995c62ab39bcf49b

[tmartino, 2017-01-20 18:44:39]

tmartino@chromium.org changed reviewers:
+ rouslan@chromium.org

[tmartino, 2017-01-20 18:44:40]

Adds the skeleton of the new page. Displays the addresses on file for this
profile.

Not yet implemented: event handlers, prettifying, adding/editing addresses

[please use gerrit instead, 2017-01-20 19:32:53]

Good stuff!

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_dialog.cc (right):

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_dialog.cc:105: true);
Please add a comment about the meaning of this "true" parameter.

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/shipping_list_view_controller.cc (right):

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_list_view_controller.cc:46: true,
Ditto

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
File components/payments/payment_request.cc (right):

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
components/payments/payment_request.cc:107: autofill::AutofillProfile*
PaymentRequest::GetSelectedShippingProfile() {
Here and below:

Simple getters and settings should use hacker_case() and are preferred to be
defined in the header file. Use const to indicate that getters don't change the
internal state of this PaymentRequest object.

autofill::AutofillProfile* selected_shipping_profile() const {
  return selected_shipping_profile_;
}

void set_selected_shipping_profile(autofill::AutofillProfile* profile) {
  selected_shipping_profile_ = profile;
}

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
File components/payments/payment_request.h (right):

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
components/payments/payment_request.h:66:
std::vector<autofill::AutofillProfile*> GetProfiles();
It would be preferable to return a const-ref of an std::vector, because it's
expensive to copy. You can accomplish this by adding two vectors as member
variables.

const std::vector<Autofill:AutofillProfile*>& shipping_profiles() const {
  return shipping_profiles_;
}

const std::vector<Autofill:AutofillProfile*>& contact_profiles() const {
  return contact_profiles_;
}

The profile pointers should point to the owned elements in profile_cache_.

Shipping and contact profiles should be kept separate because their
deduplication is different. For example, two profiles that have different city
are considered to be different shipping addresses. UI should show both of these
profiles in the shipping address section.

Payer contact details don't include a city, however, so UI should show only of
these profiles in the contact section.

[tmartino, 2017-01-25 00:08:41]

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_dialog.cc (right):

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_dialog.cc:105: true);
On 2017/01/20 at 19:32:53, rouslan wrote:
> Please add a comment about the meaning of this "true" parameter.

Done here and for the other calls to Push in this class.

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/shipping_list_view_controller.cc (right):

https://codereview.chromium.org/2643643006/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_list_view_controller.cc:46: true,
On 2017/01/20 at 19:32:53, rouslan wrote:
> Ditto

Done

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
File components/payments/payment_request.cc (right):

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
components/payments/payment_request.cc:107: autofill::AutofillProfile*
PaymentRequest::GetSelectedShippingProfile() {
On 2017/01/20 at 19:32:53, rouslan wrote:
> Here and below:
> 
> Simple getters and settings should use hacker_case() and are preferred to be
defined in the header file. Use const to indicate that getters don't change the
internal state of this PaymentRequest object.
> 
> autofill::AutofillProfile* selected_shipping_profile() const {
>   return selected_shipping_profile_;
> }
> 
> void set_selected_shipping_profile(autofill::AutofillProfile* profile) {
>   selected_shipping_profile_ = profile;
> }

Done

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
File components/payments/payment_request.h (right):

https://codereview.chromium.org/2643643006/diff/40001/components/payments/pay...
components/payments/payment_request.h:66:
std::vector<autofill::AutofillProfile*> GetProfiles();
On 2017/01/20 at 19:32:53, rouslan wrote:
> It would be preferable to return a const-ref of an std::vector, because it's
expensive to copy. You can accomplish this by adding two vectors as member
variables.
> 
> const std::vector<Autofill:AutofillProfile*>& shipping_profiles() const {
>   return shipping_profiles_;
> }
> 
> const std::vector<Autofill:AutofillProfile*>& contact_profiles() const {
>   return contact_profiles_;
> }
> 
> The profile pointers should point to the owned elements in profile_cache_.
> 
> Shipping and contact profiles should be kept separate because their
deduplication is different. For example, two profiles that have different city
are considered to be different shipping addresses. UI should show both of these
profiles in the shipping address section.
> 
> Payer contact details don't include a city, however, so UI should show only of
these profiles in the contact section.

Done.

[please use gerrit instead, 2017-01-25 15:07:48]

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
File components/payments/payment_request.cc (right):

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
components/payments/payment_request.cc:122:
base::MakeUnique<autofill::AutofillProfile>(*profiles[0]));
profiles[i]

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
File components/payments/payment_request.h (right):

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
components/payments/payment_request.h:65: // returned. The profiles returned are
copies owned by the request object.
Let's remove the word "copies". "The profiles returned are owned by the request
object" conveys sufficient information, IMHO.

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
components/payments/payment_request.h:71: // nullptr if no profile has been
selected or otherwise populated.
Let's replace the last sentence with "Can return null." Also, if you're using a
single comment for the following four methods, then please remove spaces between
the methods. That way it's more clear at a glance that this comment applies to
all of them.

[tmartino, 2017-01-25 18:48:10]

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
File components/payments/payment_request.cc (right):

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
components/payments/payment_request.cc:122:
base::MakeUnique<autofill::AutofillProfile>(*profiles[0]));
On 2017/01/25 at 15:07:47, rouslan wrote:
> profiles[i]

Good catch, thanks.

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
File components/payments/payment_request.h (right):

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
components/payments/payment_request.h:65: // returned. The profiles returned are
copies owned by the request object.
On 2017/01/25 at 15:07:48, rouslan wrote:
> Let's remove the word "copies". "The profiles returned are owned by the
request object" conveys sufficient information, IMHO.

Done

https://codereview.chromium.org/2643643006/diff/60001/components/payments/pay...
components/payments/payment_request.h:71: // nullptr if no profile has been
selected or otherwise populated.
On 2017/01/25 at 15:07:48, rouslan wrote:
> Let's replace the last sentence with "Can return null." Also, if you're using
a single comment for the following four methods, then please remove spaces
between the methods. That way it's more clear at a glance that this comment
applies to all of them.

Done

[please use gerrit instead, 2017-01-25 19:03:40]

lgtm

[tmartino, 2017-01-25 19:05:07]

tmartino@chromium.org changed reviewers:
+ sky@chromium.org

[tmartino, 2017-01-25 19:05:08]

+sky for OWNERS on /c/b/ui/*

[sky, 2017-01-25 22:00:13]

LGTM

[tmartino, 2017-01-25 22:00:43]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 22:01:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:06:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tmartino, 2017-01-25 23:34:54]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 23:35:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:50:46]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tmartino, 2017-01-26 00:23:43]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 00:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 02:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:07:14]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-01-26 16:15:54]

The CQ bit was checked by tmartino@chromium.org

[tmartino, 2017-01-26 16:15:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2643643006/#ps120001
(title: "Further rebasing")

[commit-bot: I haz the power, 2017-01-26 16:16:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 16:23:08]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485447354917090,
"parent_rev": "968048dbdb64fde8f6ac073077399dfaf42f6bb3", "commit_rev":
"36405629cb79a21a8a395592995c62ab39bcf49b"}

[commit-bot: I haz the power, 2017-01-26 16:23:52]

Description was changed from

==========
[WebPayments] Adding something resembling Shipping Address list

BUG=679449
==========

to

==========
[WebPayments] Adding something resembling Shipping Address list

BUG=679449

Review-Url: https://codereview.chromium.org/2643643006
Cr-Commit-Position: refs/heads/master@{#446343}
Committed:
https://chromium.googlesource.com/chromium/src/+/36405629cb79a21a8a395592995c...
==========

[commit-bot: I haz the power, 2017-01-26 16:23:58]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/36405629cb79a21a8a395592995c...