Convert ExternalPopupMenu Timer to TaskRunnerTimer.

Convert ExternalPopupMenu Timer to TaskRunnerTimer.

This is part of a larger effort to convert usages of global Timers to frame-specific timers.

As ExternalPopupMenu is not spec'd I have used UnspecifiedTimer as the type.

BUG=624694
Review-Url: https://codereview.chromium.org/2643623002
Cr-Commit-Position: refs/heads/master@{#453876}
Committed: https://chromium.googlesource.com/chromium/src/+/3b4238d901c571fad6799a1427adc96779067e43

[slangley, 2017-01-18 06:40:45]

The CQ bit was checked by slangley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 06:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slangley, 2017-01-18 06:42:16]

slangley@chromium.org changed reviewers:
+ sashab@chromium.org

[slangley, 2017-01-18 06:42:17]

Please take a look at this conversion to TaskRunnerTimer.

Thanks.

[sashab, 2017-01-18 06:45:08]

LGTM but put more context into CL description like 'this is part of a larger
effort to convert usages of global Timers to frame-specific timers'

[slangley, 2017-01-18 06:47:27]

Description was changed from

==========
Convert ExternalPopupMenu Timer to TaskRunnerTimer.

BUG=624694
==========

to

==========
Convert ExternalPopupMenu Timer to TaskRunnerTimer.

This is part of a larger effort to convert usages of global Timers to
frame-specific timers.

BUG=624694
==========

[slangley, 2017-01-18 06:48:01]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[commit-bot: I haz the power, 2017-01-18 08:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 08:54:21]

Dry run: This issue passed the CQ dry run.

[slangley, 2017-03-01 00:48:38]

haraken@ - ptal

[haraken, 2017-03-01 01:11:54]

Explain why you chose the task type in the CL description.

IIUC, ExternalPopupMenu is not a speced thing and thus should not use
UserInteraction. I guess this should use UnspecedTimer.

[slangley, 2017-03-01 05:51:28]

Description was changed from

==========
Convert ExternalPopupMenu Timer to TaskRunnerTimer.

This is part of a larger effort to convert usages of global Timers to
frame-specific timers.

BUG=624694
==========

to

==========
Convert ExternalPopupMenu Timer to TaskRunnerTimer.

This is part of a larger effort to convert usages of global Timers to
frame-specific timers.

As ExternalPopupMenu is not spec'd I have used UnspecifiedTimer as the type.

BUG=624694
==========

[slangley, 2017-03-01 05:51:39]

haraken@ - ptal

[haraken, 2017-03-01 05:52:16]

LGTM

[slangley, 2017-03-01 06:12:44]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-03-01 06:12:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2643623002/#ps20001
(title: "Convert to UnspecedTimer")

[commit-bot: I haz the power, 2017-03-01 06:13:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 07:43:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488348764470080,
"parent_rev": "86e6e64ff85bcc67820c5f1e53e2300e9630b0f7", "commit_rev":
"3b4238d901c571fad6799a1427adc96779067e43"}

[commit-bot: I haz the power, 2017-03-01 07:44:28]

Description was changed from

==========
Convert ExternalPopupMenu Timer to TaskRunnerTimer.

This is part of a larger effort to convert usages of global Timers to
frame-specific timers.

As ExternalPopupMenu is not spec'd I have used UnspecifiedTimer as the type.

BUG=624694
==========

to

==========
Convert ExternalPopupMenu Timer to TaskRunnerTimer.

This is part of a larger effort to convert usages of global Timers to
frame-specific timers.

As ExternalPopupMenu is not spec'd I have used UnspecifiedTimer as the type.

BUG=624694

Review-Url: https://codereview.chromium.org/2643623002
Cr-Commit-Position: refs/heads/master@{#453876}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b4238d901c571fad6799a1427ad...
==========

[commit-bot: I haz the power, 2017-03-01 07:44:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b4238d901c571fad6799a1427ad...