Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2643613003: Revert "binding: Makes window/frames/self attributes return itself." (Closed)
Patch Set: whack-a-mole Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMWindow.h
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h
index 44f155ce7800ea51195340ffa6b8df9df8768477..448360a8dd76711804121fb420dd87b1be072d21 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.h
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h
@@ -118,13 +118,9 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
virtual void setDefaultStatus(const String&) = 0;
// Self-referential attributes
- v8::Local<v8::Object> self(ScriptState*) const;
- v8::Local<v8::Object> window(ScriptState* scriptState) const {
- return self(scriptState);
- }
- v8::Local<v8::Object> frames(ScriptState* scriptState) const {
- return self(scriptState);
- }
+ DOMWindow* self() const;
+ DOMWindow* window() const { return self(); }
+ DOMWindow* frames() const { return self(); }
DOMWindow* opener() const;
DOMWindow* parent() const;
« no previous file with comments | « third_party/WebKit/LayoutTests/resources/testharnessreport.js ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698