third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 2643613003: Revert "binding: Makes window/frames/self attributes return itself."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2643613003: Revert "binding: Makes window/frames/self attributes return itself." (Closed)

Patch Set: whack-a-mole Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 2e3704b1996e71a73ee3de270a67bf39c85bb79c..3e4723950ddf5d5b5f8e47f46bf2669a907f6d40 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -81,8 +81,11 @@ unsigned DOMWindow::length() const {

return frame() ? frame()->tree().scopedChildCount() : 0;

}

-v8::Local<v8::Object> DOMWindow::self(ScriptState* scriptState) const {

- return scriptState->context()->Global();

+DOMWindow* DOMWindow::self() const {

+ if (!frame())

+ return nullptr;

+ return frame()->domWindow();

}

DOMWindow* DOMWindow::opener() const {