Issue 26436003: DevTools: display 'Pending authentication' message upon raw usb debugging.

Issue 26436003: DevTools: display 'Pending authentication' message upon raw usb debugging. (Closed)

Created:
7 years, 2 months ago by pfeldman

Modified:
7 years, 2 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: display 'Pending authentication' message upon raw usb debugging. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227710

Patch Set 2 : Review comment addressed. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -32 lines)			Patch
M	chrome/browser/devtools/adb/android_usb_device.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.h	View		2 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.cc	View		7 chunks	+37 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/port_forwarding_controller.cc	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/inspect/inspect.js	View		4 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View		6 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM https://chromiumcodereview.appspot.com/26436003/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc File chrome/browser/devtools/port_forwarding_controller.cc (right): https://chromiumcodereview.appspot.com/26436003/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc#newcode598 chrome/browser/devtools/port_forwarding_controller.cc:598: Registry::iterator rit = registry_.find(device->GetSerial()); How about adding device->IsConnected ...

7 years, 2 months ago (2013-10-08 16:42:37 UTC) #2

pfeldman

https://chromiumcodereview.appspot.com/26436003/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc File chrome/browser/devtools/port_forwarding_controller.cc (right): https://chromiumcodereview.appspot.com/26436003/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc#newcode598 chrome/browser/devtools/port_forwarding_controller.cc:598: Registry::iterator rit = registry_.find(device->GetSerial()); On 2013/10/08 16:42:37, Vladislav Kaznacheev ...

7 years, 2 months ago (2013-10-08 17:11:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/26436003/9001

7 years, 2 months ago (2013-10-09 04:32:05 UTC) #4

Message was sent while issue was closed.

Change committed as 227710

Expand Messages | Collapse Messages