Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 26436003: DevTools: display 'Pending authentication' message upon raw usb debugging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comment addressed. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/inspect_ui.h" 5 #include "chrome/browser/ui/webui/inspect_ui.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 89
90 const char kTargetTypeField[] = "type"; 90 const char kTargetTypeField[] = "type";
91 const char kAttachedField[] = "attached"; 91 const char kAttachedField[] = "attached";
92 const char kProcessIdField[] = "processId"; 92 const char kProcessIdField[] = "processId";
93 const char kRouteIdField[] = "routeId"; 93 const char kRouteIdField[] = "routeId";
94 const char kUrlField[] = "url"; 94 const char kUrlField[] = "url";
95 const char kNameField[] = "name"; 95 const char kNameField[] = "name";
96 const char kFaviconUrlField[] = "faviconUrl"; 96 const char kFaviconUrlField[] = "faviconUrl";
97 const char kDescription[] = "description"; 97 const char kDescription[] = "description";
98 const char kPidField[] = "pid"; 98 const char kPidField[] = "pid";
99 const char kAdbConnectedField[] = "adbConnected";
100 const char kAdbModelField[] = "adbModel";
99 const char kAdbSerialField[] = "adbSerial"; 101 const char kAdbSerialField[] = "adbSerial";
100 const char kAdbModelField[] = "adbModel";
101 const char kAdbBrowserProductField[] = "adbBrowserProduct"; 102 const char kAdbBrowserProductField[] = "adbBrowserProduct";
102 const char kAdbBrowserPackageField[] = "adbBrowserPackage"; 103 const char kAdbBrowserPackageField[] = "adbBrowserPackage";
103 const char kAdbBrowserVersionField[] = "adbBrowserVersion"; 104 const char kAdbBrowserVersionField[] = "adbBrowserVersion";
104 const char kAdbGlobalIdField[] = "adbGlobalId"; 105 const char kAdbGlobalIdField[] = "adbGlobalId";
105 const char kAdbBrowsersField[] = "browsers"; 106 const char kAdbBrowsersField[] = "browsers";
106 const char kAdbPagesField[] = "pages"; 107 const char kAdbPagesField[] = "pages";
107 const char kAdbPortStatus[] = "adbPortStatus"; 108 const char kAdbPortStatus[] = "adbPortStatus";
108 const char kAdbScreenWidthField[] = "adbScreenWidth"; 109 const char kAdbScreenWidthField[] = "adbScreenWidth";
109 const char kAdbScreenHeightField[] = "adbScreenHeight"; 110 const char kAdbScreenHeightField[] = "adbScreenHeight";
110 const char kAdbAttachedForeignField[] = "adbAttachedForeign"; 111 const char kAdbAttachedForeignField[] = "adbAttachedForeign";
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 port_forwarding_status = 683 port_forwarding_status =
683 port_forwarding_controller->UpdateDeviceList(*devices); 684 port_forwarding_controller->UpdateDeviceList(*devices);
684 685
685 remote_browsers_.clear(); 686 remote_browsers_.clear();
686 remote_pages_.clear(); 687 remote_pages_.clear();
687 ListValue device_list; 688 ListValue device_list;
688 for (DevToolsAdbBridge::RemoteDevices::iterator dit = devices->begin(); 689 for (DevToolsAdbBridge::RemoteDevices::iterator dit = devices->begin();
689 dit != devices->end(); ++dit) { 690 dit != devices->end(); ++dit) {
690 DevToolsAdbBridge::RemoteDevice* device = dit->get(); 691 DevToolsAdbBridge::RemoteDevice* device = dit->get();
691 DictionaryValue* device_data = new DictionaryValue(); 692 DictionaryValue* device_data = new DictionaryValue();
692 device_data->SetString(kAdbModelField, device->model()); 693 device_data->SetString(kAdbModelField, device->GetModel());
693 device_data->SetString(kAdbSerialField, device->serial()); 694 device_data->SetString(kAdbSerialField, device->GetSerial());
695 device_data->SetBoolean(kAdbConnectedField, device->IsConnected());
694 std::string device_id = base::StringPrintf( 696 std::string device_id = base::StringPrintf(
695 "device:%s", 697 "device:%s",
696 device->serial().c_str()); 698 device->GetSerial().c_str());
697 device_data->SetString(kAdbGlobalIdField, device_id); 699 device_data->SetString(kAdbGlobalIdField, device_id);
698 ListValue* browser_list = new ListValue(); 700 ListValue* browser_list = new ListValue();
699 device_data->Set(kAdbBrowsersField, browser_list); 701 device_data->Set(kAdbBrowsersField, browser_list);
700 702
701 DevToolsAdbBridge::RemoteBrowsers& browsers = device->browsers(); 703 DevToolsAdbBridge::RemoteBrowsers& browsers = device->browsers();
702 for (DevToolsAdbBridge::RemoteBrowsers::iterator bit = 704 for (DevToolsAdbBridge::RemoteBrowsers::iterator bit =
703 browsers.begin(); bit != browsers.end(); ++bit) { 705 browsers.begin(); bit != browsers.end(); ++bit) {
704 DevToolsAdbBridge::RemoteBrowser* browser = bit->get(); 706 DevToolsAdbBridge::RemoteBrowser* browser = bit->get();
705 DictionaryValue* browser_data = new DictionaryValue(); 707 DictionaryValue* browser_data = new DictionaryValue();
706 browser_data->SetString(kAdbBrowserProductField, browser->product()); 708 browser_data->SetString(kAdbBrowserProductField, browser->product());
707 browser_data->SetString(kAdbBrowserPackageField, browser->package()); 709 browser_data->SetString(kAdbBrowserPackageField, browser->package());
708 browser_data->SetString(kAdbBrowserVersionField, browser->version()); 710 browser_data->SetString(kAdbBrowserVersionField, browser->version());
709 std::string browser_id = base::StringPrintf( 711 std::string browser_id = base::StringPrintf(
710 "browser:%s:%s:%s", 712 "browser:%s:%s:%s",
711 device->serial().c_str(), 713 device->GetSerial().c_str(),
712 browser->product().c_str(), // Force sorting by product name. 714 browser->product().c_str(), // Force sorting by product name.
713 browser->socket().c_str()); 715 browser->socket().c_str());
714 browser_data->SetString(kAdbGlobalIdField, browser_id); 716 browser_data->SetString(kAdbGlobalIdField, browser_id);
715 remote_browsers_[browser_id] = browser; 717 remote_browsers_[browser_id] = browser;
716 ListValue* page_list = new ListValue(); 718 ListValue* page_list = new ListValue();
717 browser_data->Set(kAdbPagesField, page_list); 719 browser_data->Set(kAdbPagesField, page_list);
718 720
719 DevToolsAdbBridge::RemotePages& pages = browser->pages(); 721 DevToolsAdbBridge::RemotePages& pages = browser->pages();
720 for (DevToolsAdbBridge::RemotePages::iterator it = 722 for (DevToolsAdbBridge::RemotePages::iterator it =
721 pages.begin(); it != pages.end(); ++it) { 723 pages.begin(); it != pages.end(); ++it) {
722 DevToolsAdbBridge::RemotePage* page = it->get(); 724 DevToolsAdbBridge::RemotePage* page = it->get();
723 DictionaryValue* page_data = BuildTargetDescriptor( 725 DictionaryValue* page_data = BuildTargetDescriptor(
724 kAdbTargetType, page->attached(), 726 kAdbTargetType, page->attached(),
725 GURL(page->url()), page->title(), GURL(page->favicon_url()), 727 GURL(page->url()), page->title(), GURL(page->favicon_url()),
726 page->description(), 0, 0); 728 page->description(), 0, 0);
727 std::string page_id = base::StringPrintf("page:%s:%s:%s", 729 std::string page_id = base::StringPrintf("page:%s:%s:%s",
728 device->serial().c_str(), 730 device->GetSerial().c_str(),
729 browser->socket().c_str(), 731 browser->socket().c_str(),
730 page->id().c_str()); 732 page->id().c_str());
731 page_data->SetString(kAdbGlobalIdField, page_id); 733 page_data->SetString(kAdbGlobalIdField, page_id);
732 page_data->SetBoolean(kAdbAttachedForeignField, 734 page_data->SetBoolean(kAdbAttachedForeignField,
733 page->attached() && !page->HasDevToolsWindow()); 735 page->attached() && !page->HasDevToolsWindow());
734 // Pass the screen size in the page object to make sure that 736 // Pass the screen size in the page object to make sure that
735 // the caching logic does not prevent the page item from updating 737 // the caching logic does not prevent the page item from updating
736 // when the screen size changes. 738 // when the screen size changes.
737 gfx::Size screen_size = device->GetScreenSize(); 739 gfx::Size screen_size = device->screen_size();
738 page_data->SetInteger(kAdbScreenWidthField, screen_size.width()); 740 page_data->SetInteger(kAdbScreenWidthField, screen_size.width());
739 page_data->SetInteger(kAdbScreenHeightField, screen_size.height()); 741 page_data->SetInteger(kAdbScreenHeightField, screen_size.height());
740 remote_pages_[page_id] = page; 742 remote_pages_[page_id] = page;
741 page_list->Append(page_data); 743 page_list->Append(page_data);
742 } 744 }
743 browser_list->Append(browser_data); 745 browser_list->Append(browser_data);
744 } 746 }
745 747
746 if (port_forwarding_controller) { 748 if (port_forwarding_controller) {
747 PortForwardingController::DevicesStatus::iterator sit = 749 PortForwardingController::DevicesStatus::iterator sit =
748 port_forwarding_status.find(device->serial()); 750 port_forwarding_status.find(device->GetSerial());
749 if (sit != port_forwarding_status.end()) { 751 if (sit != port_forwarding_status.end()) {
750 DictionaryValue* port_status_dict = new DictionaryValue(); 752 DictionaryValue* port_status_dict = new DictionaryValue();
751 typedef PortForwardingController::PortStatusMap StatusMap; 753 typedef PortForwardingController::PortStatusMap StatusMap;
752 const StatusMap& port_status = sit->second; 754 const StatusMap& port_status = sit->second;
753 for (StatusMap::const_iterator it = port_status.begin(); 755 for (StatusMap::const_iterator it = port_status.begin();
754 it != port_status.end(); ++it) { 756 it != port_status.end(); ++it) {
755 port_status_dict->SetInteger( 757 port_status_dict->SetInteger(
756 base::StringPrintf("%d", it->first), it->second); 758 base::StringPrintf("%d", it->first), it->second);
757 } 759 }
758 device_data->Set(kAdbPortStatus, port_status_dict); 760 device_data->Set(kAdbPortStatus, port_status_dict);
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 base::DictionaryValue default_config; 822 base::DictionaryValue default_config;
821 default_config.SetString( 823 default_config.SetString(
822 kPortForwardingDefaultPort, kPortForwardingDefaultLocation); 824 kPortForwardingDefaultPort, kPortForwardingDefaultLocation);
823 prefs->Set(prefs::kDevToolsPortForwardingConfig, default_config); 825 prefs->Set(prefs::kDevToolsPortForwardingConfig, default_config);
824 } 826 }
825 827
826 const base::Value* InspectUI::GetPrefValue(const char* name) { 828 const base::Value* InspectUI::GetPrefValue(const char* name) {
827 Profile* profile = Profile::FromWebUI(web_ui()); 829 Profile* profile = Profile::FromWebUI(web_ui());
828 return profile->GetPrefs()->FindPreference(name)->GetValue(); 830 return profile->GetPrefs()->FindPreference(name)->GetValue();
829 } 831 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698