Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

Issue 2643593002: Convert BookmarkTabHelper to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_tab_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
index fdad3b932b54a27e34f3983e7ea2a227f6f14003..ced69d55e2715dc0326cce873ba5b7501e911fab 100644
--- a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
@@ -125,15 +125,13 @@ void BookmarkTabHelper::BookmarkNodeChanged(BookmarkModel* model,
UpdateStarredStateForCurrentURL();
}
-void BookmarkTabHelper::DidNavigateMainFrame(
- const content::LoadCommittedDetails& /*details*/,
- const content::FrameNavigateParams& /*params*/) {
+void BookmarkTabHelper::DidStartNavigation(
+ content::NavigationHandle* navigation_handle) {
UpdateStarredStateForCurrentURL();
}
-void BookmarkTabHelper::DidStartNavigationToPendingEntry(
- const GURL& /*url*/,
- content::ReloadType /*reload_type*/) {
+void BookmarkTabHelper::DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) {
UpdateStarredStateForCurrentURL();
}
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_tab_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698