Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

Issue 2643593002: Convert BookmarkTabHelper to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_tab_helper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 5 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/defaults.h" 9 #include "chrome/browser/defaults.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 BookmarkModel* model, 118 BookmarkModel* model,
119 const std::set<GURL>& removed_urls) { 119 const std::set<GURL>& removed_urls) {
120 UpdateStarredStateForCurrentURL(); 120 UpdateStarredStateForCurrentURL();
121 } 121 }
122 122
123 void BookmarkTabHelper::BookmarkNodeChanged(BookmarkModel* model, 123 void BookmarkTabHelper::BookmarkNodeChanged(BookmarkModel* model,
124 const BookmarkNode* node) { 124 const BookmarkNode* node) {
125 UpdateStarredStateForCurrentURL(); 125 UpdateStarredStateForCurrentURL();
126 } 126 }
127 127
128 void BookmarkTabHelper::DidNavigateMainFrame( 128 void BookmarkTabHelper::DidStartNavigation(
129 const content::LoadCommittedDetails& /*details*/, 129 content::NavigationHandle* navigation_handle) {
130 const content::FrameNavigateParams& /*params*/) {
131 UpdateStarredStateForCurrentURL(); 130 UpdateStarredStateForCurrentURL();
132 } 131 }
133 132
134 void BookmarkTabHelper::DidStartNavigationToPendingEntry( 133 void BookmarkTabHelper::DidFinishNavigation(
135 const GURL& /*url*/, 134 content::NavigationHandle* navigation_handle) {
136 content::ReloadType /*reload_type*/) {
137 UpdateStarredStateForCurrentURL(); 135 UpdateStarredStateForCurrentURL();
138 } 136 }
139 137
140 void BookmarkTabHelper::DidAttachInterstitialPage() { 138 void BookmarkTabHelper::DidAttachInterstitialPage() {
141 // Interstitials are not necessarily starred just because the page that 139 // Interstitials are not necessarily starred just because the page that
142 // created them is, so star state has to track interstitial attach/detach if 140 // created them is, so star state has to track interstitial attach/detach if
143 // necessary. 141 // necessary.
144 UpdateStarredStateForCurrentURL(); 142 UpdateStarredStateForCurrentURL();
145 } 143 }
146 144
147 void BookmarkTabHelper::DidDetachInterstitialPage() { 145 void BookmarkTabHelper::DidDetachInterstitialPage() {
148 UpdateStarredStateForCurrentURL(); 146 UpdateStarredStateForCurrentURL();
149 } 147 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_tab_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698