Improve "turn on Bluetooth" flow (another approach)

Improve "turn on Bluetooth" flow (another approach)

When Bluetooth is off on the device, the "device settings" link will
open a device settings page where users can turn on Bluetooth. This
CL modifies the link to directly turn on the Bluetooth adapter. While
turning on the adapter, the throbber is shown to indicate that. This
simplifies the "turn on Bluetooth" flow by staying on the same web
bluetooth application page.

I uploaded some screenshots on the issue page.

BUG=676639
Review-Url: https://codereview.chromium.org/2643573002
Cr-Commit-Position: refs/heads/master@{#444505}
Committed: https://chromium.googlesource.com/chromium/src/+/1bb6a96b7a6aa53e2a9834a2939bc60f1a40a661

[juncai, 2017-01-17 22:57:52]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 22:59:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:34:27]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-01-18 00:01:20]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:02:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:41:48]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-01-18 01:19:11]

juncai@chromium.org changed reviewers:
+ tedchoc@chromium.org

[juncai, 2017-01-18 01:19:12]

Please take a look.

[Ted C, 2017-01-18 06:04:05]

lgtm w/ a naming tweak suggestion

https://codereview.chromium.org/2643573002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2643573002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:522:
public void turnOnAdapter() {
I think turn on and TURNING_ON are a bit "bluetooth"-y to me.  Also, the javadoc
seems very specific to bluetooth as well.

State.INITIALIZING_ADAPTER is probably more generic.

Although I don't have a good name for how to turn that into a method name.

But I guess STARTING and INITIALIZING are a bit hard to distinguish as well.

Maybe INITIALIZING and GATHERING_DATA would potentially be better long term
options.

signalInitializingAdapter or something as a potential method name suggestion.

[juncai, 2017-01-18 19:20:59]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 19:21:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 19:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:53:34]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-01-18 20:24:39]

https://codereview.chromium.org/2643573002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2643573002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:522:
public void turnOnAdapter() {
On 2017/01/18 06:04:05, Ted C wrote:
> I think turn on and TURNING_ON are a bit "bluetooth"-y to me.  Also, the
javadoc
> seems very specific to bluetooth as well.
> 
> State.INITIALIZING_ADAPTER is probably more generic.
> 
> Although I don't have a good name for how to turn that into a method name.
> 
> But I guess STARTING and INITIALIZING are a bit hard to distinguish as well.
> 
> Maybe INITIALIZING and GATHERING_DATA would potentially be better long term
> options.
> 
> signalInitializingAdapter or something as a potential method name suggestion.

Done.

[juncai, 2017-01-18 21:56:23]

The CQ bit was checked by juncai@chromium.org

[juncai, 2017-01-18 21:56:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2643573002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-01-18 21:56:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:03:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484776583529920,
"parent_rev": "4a86a5def753c5392ca4a0b21d6ebf409cd44726", "commit_rev":
"1bb6a96b7a6aa53e2a9834a2939bc60f1a40a661"}

[commit-bot: I haz the power, 2017-01-18 22:04:17]

Description was changed from

==========
Improve "turn on Bluetooth" flow (another approach)

When Bluetooth is off on the device, the "device settings" link will
open a device settings page where users can turn on Bluetooth. This
CL modifies the link to directly turn on the Bluetooth adapter. While
turning on the adapter, the throbber is shown to indicate that. This
simplifies the "turn on Bluetooth" flow by staying on the same web
bluetooth application page.

I uploaded some screenshots on the issue page.

BUG=676639
==========

to

==========
Improve "turn on Bluetooth" flow (another approach)

When Bluetooth is off on the device, the "device settings" link will
open a device settings page where users can turn on Bluetooth. This
CL modifies the link to directly turn on the Bluetooth adapter. While
turning on the adapter, the throbber is shown to indicate that. This
simplifies the "turn on Bluetooth" flow by staying on the same web
bluetooth application page.

I uploaded some screenshots on the issue page.

BUG=676639

Review-Url: https://codereview.chromium.org/2643573002
Cr-Commit-Position: refs/heads/master@{#444505}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bb6a96b7a6aa53e2a9834a2939b...
==========

[commit-bot: I haz the power, 2017-01-18 22:04:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1bb6a96b7a6aa53e2a9834a2939b...