Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2643563003: Fix leak with accessibility/misspellings.html (Closed)

Created:
3 years, 11 months ago by Xiaocheng
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix leak with accessibility/misspellings.html The layout test is currently leaking because of unrun callbacks of |testRunner.runIdleTasks()|. This patch stops the leak by removing the call of |testRunner.runIdleTasks()|. BUG=517298 Review-Url: https://codereview.chromium.org/2643563003 Cr-Commit-Position: refs/heads/master@{#444270} Committed: https://chromium.googlesource.com/chromium/src/+/21bbb69c4b34001577e76139604ccc7715089bd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/misspellings.html View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Xiaocheng
PTAL.
3 years, 11 months ago (2017-01-18 02:55:29 UTC) #5
yosin_UTC9
lgtm We should introduce TestRunner.runAllPendingIdleTasks() in the future.
3 years, 11 months ago (2017-01-18 03:59:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643563003/1
3 years, 11 months ago (2017-01-18 04:08:22 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 04:18:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21bbb69c4b34001577e76139604c...

Powered by Google App Engine
This is Rietveld 408576698