Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2643563002: Whitespace test of CQ. (Closed)

Created:
3 years, 11 months ago by tandrii(chromium)
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Whitespace test of CQ. TBR=machenbach@chromium.org NOPRESUBMIT=True NOTRY=True BUG=644915 Review-Url: https://codereview.chromium.org/2643563002 Cr-Commit-Position: refs/heads/master@{#42429} Committed: https://chromium.googlesource.com/v8/v8/+/c236fe1459db363b56b23d841a7af141aaf6f21c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/whitespace.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
tandrii(chromium)
3 years, 11 months ago (2017-01-17 22:50:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643563002/1
3 years, 11 months ago (2017-01-17 22:50:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643563002/1
3 years, 11 months ago (2017-01-17 22:58:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/c236fe1459db363b56b23d841a7af141aaf6f21c
3 years, 11 months ago (2017-01-17 23:00:44 UTC) #11
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-18 07:40:20 UTC) #12
Michael Achenbach
Are you sure about the referenced bug?? Typo?
3 years, 11 months ago (2017-01-18 07:41:38 UTC) #13
tandrii(chromium)
3 years, 11 months ago (2017-01-19 00:14:28 UTC) #14
Message was sent while issue was closed.
yeah, definitely typo. The right bug is 644915

Powered by Google App Engine
This is Rietveld 408576698