Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2643543002: Stop using Encoding array to get unicode from charcode in Type 3 fonts (Closed)

Created:
3 years, 11 months ago by npm
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Stop using Encoding array to get unicode from charcode in Type 3 fonts We should not fill out the m_Encoding for Type3 fonts. This way, we stop getting garbage characters from text extraction. Guessing that unicode == charcode (in the absence of ToUnicode) is our best bet. BUG=pdfium:642 Review-Url: https://codereview.chromium.org/2643543002 Committed: https://pdfium.googlesource.com/pdfium/+/21ae2b7297e005576afeb9f0230d1f69b3abc857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M core/fpdfapi/font/cpdf_type3font.cpp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
npm
ptal
3 years, 11 months ago (2017-01-17 22:40:55 UTC) #3
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-17 23:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643543002/1
3 years, 11 months ago (2017-01-17 23:04:03 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 23:15:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/21ae2b7297e005576afeb9f0230d1f69b3ab...

Powered by Google App Engine
This is Rietveld 408576698