Adding a unit test to RenderWidgetHostViewAura

Adding a unit test to RenderWidgetHostViewAura

This CL adds a test similar to
InputMethodMacTest.ImeCancelCompositionForAllViews for Aura.

BUG=602723
Review-Url: https://codereview.chromium.org/2643503002
Cr-Commit-Position: refs/heads/master@{#444176}
Committed: https://chromium.googlesource.com/chromium/src/+/df66adcb39e831a54a35a795baf7267c9a3925f5

[EhsanK, 2017-01-17 21:43:31]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2017-01-17 21:43:32]

Charlie,
This is the missing test (from Aura) we talked about in
https://codereview.chromium.org/2613263002/. PTAL.

Thanks.

[EhsanK, 2017-01-17 21:43:49]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 21:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 22:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:12:16]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2017-01-17 22:31:39]

Thanks!  LGTM with nit.

https://codereview.chromium.org/2643503002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2643503002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4762:
view->ImeCancelComposition();
nit: Put EXPECT_TRUE(has_composition_text()) before this line?

[EhsanK, 2017-01-17 22:45:48]

PTAL.

https://codereview.chromium.org/2643503002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2643503002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4762:
view->ImeCancelComposition();
On 2017/01/17 22:31:38, Charlie Reis wrote:
> nit: Put EXPECT_TRUE(has_composition_text()) before this line?

It will definitely help with readability of the test. But we already have the
same expect inside SetHasCompositionTextToTrue(). Is it still recommended to put
the same one here as well?

[Charlie Reis, 2017-01-17 22:49:20]

https://codereview.chromium.org/2643503002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
(right):

https://codereview.chromium.org/2643503002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4762:
view->ImeCancelComposition();
On 2017/01/17 22:45:47, EhsanK wrote:
> On 2017/01/17 22:31:38, Charlie Reis wrote:
> > nit: Put EXPECT_TRUE(has_composition_text()) before this line?
> 
> It will definitely help with readability of the test. But we already have the
> same expect inside SetHasCompositionTextToTrue(). Is it still recommended to
put
> the same one here as well?

Oh, I didn't see that before.  It's ok as is then.

[EhsanK, 2017-01-17 22:52:21]

Thanks Charlie! CQ-ing now.

[EhsanK, 2017-01-17 22:52:27]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:53:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:07:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484693547532820, "parent_rev":
"1b769b1c19470c4df1b369bd4ebfeb40afc4dc3d", "commit_rev":
"df66adcb39e831a54a35a795baf7267c9a3925f5"}

[commit-bot: I haz the power, 2017-01-17 23:08:19]

Description was changed from

==========
Adding a unit test to RenderWidgetHostViewAura

This CL adds a test similar to
InputMethodMacTest.ImeCancelCompositionForAllViews for Aura.

BUG=602723
==========

to

==========
Adding a unit test to RenderWidgetHostViewAura

This CL adds a test similar to
InputMethodMacTest.ImeCancelCompositionForAllViews for Aura.

BUG=602723

Review-Url: https://codereview.chromium.org/2643503002
Cr-Commit-Position: refs/heads/master@{#444176}
Committed:
https://chromium.googlesource.com/chromium/src/+/df66adcb39e831a54a35a795baf7...
==========

[commit-bot: I haz the power, 2017-01-17 23:08:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df66adcb39e831a54a35a795baf7...