Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: remoting/base/telemetry_log_writer.h

Issue 2643483003: [Remoting Android] Refactor ClientTelemetryLogger (Closed)
Patch Set: PTAL Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/telemetry_log_writer.h
diff --git a/remoting/base/telemetry_log_writer.h b/remoting/base/telemetry_log_writer.h
index 2db50004b07411c27d38ce45fd9fcb29ac7d9906..5a7237ce61548d905931990367b7de9ed302540e 100644
--- a/remoting/base/telemetry_log_writer.h
+++ b/remoting/base/telemetry_log_writer.h
@@ -43,6 +43,9 @@ class TelemetryLogWriter : public ChromotingEventLogWriter {
// Push the log entry to the pending list and send out all the pending logs.
void Log(const ChromotingEvent& entry) override;
+ // Can be called on any thread.
Sergey Ulanov 2017/01/19 00:50:38 Do we actually need to allow it to be called on an
Yuwei 2017/01/19 23:00:00 Obsolete.
+ base::WeakPtr<TelemetryLogWriter> GetWeakPtr();
+
~TelemetryLogWriter() override;
private:
@@ -64,6 +67,8 @@ class TelemetryLogWriter : public ChromotingEventLogWriter {
// These will be pushed back to pending_entries if error occurs.
std::deque<ChromotingEvent> sending_entries_;
+ base::WeakPtr<TelemetryLogWriter> weak_ptr_;
+ base::WeakPtrFactory<TelemetryLogWriter> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(TelemetryLogWriter);
Sergey Ulanov 2017/01/19 00:50:38 nit: add empty line here
Yuwei 2017/01/19 23:00:00 Obsolete.
};

Powered by Google App Engine
This is Rietveld 408576698