[Remoting Android] Refactor ClientTelemetryLogger

remoting/base/telemetry_log_writer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_BASE_TELEMETRY_LOG_WRITER_H_
 #define REMOTING_BASE_TELEMETRY_LOG_WRITER_H_
 
 #include <deque>
 #include <string>
 
@@ skipping 25 matching lines @@
 
   // The closure will be called when the request fails with unauthorized error
   // code. The closure should call SetAuthToken to set the token.
   // If the closure is not set, the log writer will try to resend the logs
   // immediately.
   void SetAuthClosure(const base::Closure& closure) override;
 
   // Push the log entry to the pending list and send out all the pending logs.
   void Log(const ChromotingEvent& entry) override;
 
+  // Can be called on any thread.

[Sergey Ulanov, 2017/01/19 00:50:38]

Do we actually need to allow it to be called on any thread, given that it's
usable only on one thread?

[Yuwei, 2017/01/19 23:00:00]

Obsolete.

+  base::WeakPtr<TelemetryLogWriter> GetWeakPtr();
+
   ~TelemetryLogWriter() override;
 
  private:
   void SendPendingEntries();
   void PostJsonToServer(const std::string& json);
   void OnSendLogResult(const remoting::UrlRequest::Result& result);
 
   base::ThreadChecker thread_checker_;
   std::string telemetry_base_url_;
   std::unique_ptr<UrlRequestFactory> request_factory_;
   std::string auth_token_;
   base::Closure auth_closure_;
   std::unique_ptr<UrlRequest> request_;
 
   // Entries to be sent.
   std::deque<ChromotingEvent> pending_entries_;
 
   // Entries being sent.
   // These will be pushed back to pending_entries if error occurs.
   std::deque<ChromotingEvent> sending_entries_;
 
+  base::WeakPtr<TelemetryLogWriter> weak_ptr_;
+  base::WeakPtrFactory<TelemetryLogWriter> weak_factory_;
   DISALLOW_COPY_AND_ASSIGN(TelemetryLogWriter);

[Sergey Ulanov, 2017/01/19 00:50:38]

nit: add empty line here

[Yuwei, 2017/01/19 23:00:00]

Obsolete.

 };
 
 }  // namespace remoting
 #endif  // REMOTING_BASE_TELEMETRY_LOG_WRITER_H_