[Remoting Android] Refactor ClientTelemetryLogger

remoting/base/telemetry_log_writer.cc

Index: remoting/base/telemetry_log_writer.cc
diff --git a/remoting/base/telemetry_log_writer.cc b/remoting/base/telemetry_log_writer.cc
index 1c0cbe37b9101d4db5f2bb6bc142bf863efcdeb5..728b721cab51653e95b9c5a4e58c5a2e3c802e50 100644
--- a/remoting/base/telemetry_log_writer.cc
+++ b/remoting/base/telemetry_log_writer.cc
@@ -18,7 +18,10 @@ TelemetryLogWriter::TelemetryLogWriter(
     const std::string& telemetry_base_url,
     std::unique_ptr<UrlRequestFactory> request_factory)
     : telemetry_base_url_(telemetry_base_url),
-      request_factory_(std::move(request_factory)) {}
+      request_factory_(std::move(request_factory)),
+      weak_factory_(this) {
+  weak_ptr_ = weak_factory_.GetWeakPtr();

[Sergey Ulanov, 2017/01/19 00:50:38]

this can be initialized in the initializer list above (if you move weak_ptr_
after weak_factory_), but weak_ptr can be removed completely if GetWeakPtr()
doesn't need to be thread-safe.

[Yuwei, 2017/01/19 23:00:00]

Obsolete.

BTW I don't think you can move weak_ptr_ after weak_factory_ since weak_factory_
is supposed to be the last member to initialize so that it can get destroyed
first.

[Sergey Ulanov, 2017/01/23 00:36:49]

Yes, it's better to keep WeakFactory last, but in practice it makes any
difference very rarely. In this case it certainly doesn't matter - it's safe to
destroy weak_ptr_ before WeakFactory.

[Yuwei, 2017/01/23 02:19:47]

Acknowledged.

+}
 TelemetryLogWriter::~TelemetryLogWriter() {}
 
 void TelemetryLogWriter::SetAuthToken(const std::string& auth_token) {
@@ -38,6 +41,10 @@ void TelemetryLogWriter::Log(const ChromotingEvent& entry) {
   SendPendingEntries();
 }
 
+base::WeakPtr<TelemetryLogWriter> TelemetryLogWriter::GetWeakPtr() {
+  return weak_ptr_;
+}
+
 void TelemetryLogWriter::SendPendingEntries() {
   DCHECK(thread_checker_.CalledOnValidThread());
   if (request_ || pending_entries_.empty()) {