Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2643373002: Signin: Reuse existing "update gms" dialogs when possible. (Closed)

Created:
3 years, 11 months ago by estevenson
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Signin: Reuse existing "update gms" dialogs when possible. Currently, |updateAccounts()| is sometimes called multiple times in AccountSigninView which results in multiple "update GMS" dialogs being generated, and the user must click back three times for the dialogs to disappear. This CL changes signin to re-use existing dialogs where possible and always remove old dialogs before creating a new one. BUG=679851 Review-Url: https://codereview.chromium.org/2626083004 Cr-Commit-Position: refs/heads/master@{#443349} (cherry picked from commit 5a7ffae71d0dcf646d26ef202f8d1882587724c7) Review-Url: https://codereview.chromium.org/2643373002 . Cr-Commit-Position: refs/branch-heads/2924@{#827} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/0851a76d19a01b08e8d65122a12a7a384ca8b91c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java View 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estevenson
3 years, 11 months ago (2017-01-20 23:47:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0851a76d19a01b08e8d65122a12a7a384ca8b91c.

Powered by Google App Engine
This is Rietveld 408576698