Chromium Code Reviews
DescriptionSignin: Reuse existing "update gms" dialogs when possible.
Currently, |updateAccounts()| is sometimes called multiple times in
AccountSigninView which results in multiple "update GMS" dialogs being
generated, and the user must click back three times for the dialogs to
disappear.
This CL changes signin to re-use existing dialogs where possible and
always remove old dialogs before creating a new one.
BUG=679851
Review-Url: https://codereview.chromium.org/2626083004
Cr-Commit-Position: refs/heads/master@{#443349}
(cherry picked from commit 5a7ffae71d0dcf646d26ef202f8d1882587724c7)
Review-Url: https://codereview.chromium.org/2643373002 .
Cr-Commit-Position: refs/branch-heads/2924@{#827}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/0851a76d19a01b08e8d65122a12a7a384ca8b91c
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||