LogDog: Use server/auth for authentication.

LogDog: Use server/auth for authentication.

Use server/auth instead of common/auth for authentication. The
server/auth package is oriented to long-running services that operate on
multiple authentication credentials throughout their lifetime. This
incorporates caching and parity with other services.

BUG=chromium:682465
TEST=unit,development
  - Deployed to development server, seems to work.

Review-Url: https://codereview.chromium.org/2643363002
Committed: https://github.com/luci/luci-go/commit/2ba0c2640117fc2b6b72724d4c2324101559c9f6

[dnj, 2017-01-20 23:32:02]

Patchset #1 (id:1) has been deleted

[dnj, 2017-01-20 23:32:52]

Patchset #1 (id:20001) has been deleted

[dnj, 2017-01-20 23:40:33]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, vadimsh@chromium.org

[dnj, 2017-01-20 23:40:33]

PTAL

[Vadim Sh., 2017-01-20 23:59:39]

lgtm, seems fine

[iannucci, 2017-01-21 00:37:00]

lgtm

https://codereview.chromium.org/2643363002/diff/60001/logdog/server/service/r...
File logdog/server/service/rt.go (right):

https://codereview.chromium.org/2643363002/diff/60001/logdog/server/service/r...
logdog/server/service/rt.go:18: func (smt *serviceModifyingTransport)
roundTripper(base http.RoundTripper) http.RoundTripper {
this seems like maybe we should do this everywhere, somehow...

[dnj, 2017-01-21 04:10:36]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-01-21 04:10:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 04:11:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 04:11:57]

Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/33d809da1aa60d10)
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/33d809db118a9510)
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/33d809d9aa457710)

[dnj, 2017-01-21 04:41:48]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-01-21 04:41:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
vadimsh@chromium.org, iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2643363002/#ps80001
(title: "LogDog: Use server/auth for authentication.")

[commit-bot: I haz the power, 2017-01-21 04:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 04:48:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484973708756600,
"parent_rev": "ee266e37c9d7e787fe9d9d72348136ada6287340", "commit_rev":
"2ba0c2640117fc2b6b72724d4c2324101559c9f6"}

[commit-bot: I haz the power, 2017-01-21 04:48:13]

Description was changed from

==========
LogDog: Use server/auth for authentication.

Use server/auth instead of common/auth for authentication. The
server/auth package is oriented to long-running services that operate on
multiple authentication credentials throughout their lifetime. This
incorporates caching and parity with other services.

BUG=chromium:682465
TEST=unit,development
  - Deployed to development server, seems to work.
==========

to

==========
LogDog: Use server/auth for authentication.

Use server/auth instead of common/auth for authentication. The
server/auth package is oriented to long-running services that operate on
multiple authentication credentials throughout their lifetime. This
incorporates caching and parity with other services.

BUG=chromium:682465
TEST=unit,development
  - Deployed to development server, seems to work.

Review-Url: https://codereview.chromium.org/2643363002
Committed:
https://github.com/luci/luci-go/commit/2ba0c2640117fc2b6b72724d4c2324101559c9f6
==========

[commit-bot: I haz the power, 2017-01-21 04:48:14]

Committed patchset #3 (id:80001) as
https://github.com/luci/luci-go/commit/2ba0c2640117fc2b6b72724d4c2324101559c9f6