DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=648707
TBR=kbr

Review-Url: https://codereview.chromium.org/2643343002
Cr-Commit-Position: refs/heads/master@{#446156}
Committed: https://chromium.googlesource.com/chromium/src/+/b8cf426b59b931395bfe5114c7c6952473f210ce

[ccameron, 2017-01-20 22:23:55]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 22:24:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 23:30:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2017-01-20 23:51:27]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:51:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-20 23:52:09]

Description was changed from

==========
DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=658265
==========

to

==========
DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=648707
==========

[ccameron, 2017-01-21 00:19:07]

ccameron@chromium.org changed reviewers:
+ pdr@chromium.org

[ccameron, 2017-01-21 00:19:34]

ptal (I know this isn't so much your area, but the main owner is OOO for a week)

[commit-bot: I haz the power, 2017-01-21 01:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:59:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2017-01-21 02:02:54]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 02:03:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 04:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 04:14:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pdr., 2017-01-23 01:10:13]

On 2017/01/21 at 00:19:34, ccameron wrote:
> ptal (I know this isn't so much your area, but the main owner is OOO for a
week)

This code looks correct to me but I don't know enough about this area to be able
to stamp it :/ Could you try qiankun.miao or possibly kbr or kainino?

[ccameron, 2017-01-25 02:50:09]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 02:50:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-25 02:58:11]

ccameron@chromium.org changed reviewers:
+ kainino@chromium.org

[ccameron, 2017-01-25 02:58:12]

Adding kainino@ to take a look at DrawingBuffer changes

Adding esprehn as OWNER of content/renderer

[commit-bot: I haz the power, 2017-01-25 04:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 04:45:03]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2017-01-25 22:55:55]

On 2017/01/25 02:58:12, ccameron wrote:
> Adding kainino@ to take a look at DrawingBuffer changes
> 
> Adding esprehn as OWNER of content/renderer

I'm not super comfortable in DrawingBuffer but the changes there seem GTM.

[ccameron, 2017-01-25 22:58:25]

Description was changed from

==========
DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=648707
==========

to

==========
DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=648707
TBR=kbr
==========

[ccameron, 2017-01-25 22:58:26]

ccameron@chromium.org changed reviewers:
+ kbr@chromium.org

[ccameron, 2017-01-25 22:59:26]

Okay, I think kbr is the only OWNER who is comfortable reviewing this. TBRing
this since he's OOO.

[ccameron, 2017-01-25 23:00:06]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-01-25 23:00:22]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:00:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485385222159250,
"parent_rev": "686dbbef585fd2064f1a2a3451b90e501936a589", "commit_rev":
"b8cf426b59b931395bfe5114c7c6952473f210ce"}

[commit-bot: I haz the power, 2017-01-25 23:10:03]

Description was changed from

==========
DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=648707
TBR=kbr
==========

to

==========
DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG=648707
TBR=kbr

Review-Url: https://codereview.chromium.org/2643343002
Cr-Commit-Position: refs/heads/master@{#446156}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8cf426b59b931395bfe5114c7c6...
==========

[commit-bot: I haz the power, 2017-01-25 23:10:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b8cf426b59b931395bfe5114c7c6...

[danakj, 2017-01-25 23:43:37]

On Wed, Jan 25, 2017 at 5:59 PM, <ccameron@chromium.org> wrote:

> Okay, I think kbr is the only OWNER who is comfortable reviewing this.
> TBRing
> this since he's OOO.
>

You could try other webgl people maybe such as zmo.


>
> https://codereview.chromium.org/2643343002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2017-01-25 23:43:39]

On Wed, Jan 25, 2017 at 5:59 PM, <ccameron@chromium.org> wrote:

> Okay, I think kbr is the only OWNER who is comfortable reviewing this.
> TBRing
> this since he's OOO.
>

You could try other webgl people maybe such as zmo.


>
> https://codereview.chromium.org/2643343002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Russell (switch to Gerrit), 2017-01-28 00:30:58]

LGTM after the fact. Would have suggested both zmo and junov as other potential
reviewers.