Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2643333002: Convert USE_PROPRIETARY_CODECS to a buildflag header. (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, droger+watchlist_chromium.org, feature-media-reviews_chromium.org, Lei Zhang, chfremer+watch_chromium.org, sdefresne+watchlist_chromium.org, jam, jasonroberts+watch_google.com, tommycli, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, blundell+watchlist_chromium.org, imcheng+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, isheriff+watch_chromium.org, eme-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert USE_PROPRIETARY_CODECS to a buildflag header. Convert the preprocessor define to a buildflag //header defined in //media. The build arg is kept in //build/config/features.gni due to a dependency on WebRTC (described in a comment). Reland of https://codereview.chromium.org/2572883002 with no changes. I believe the cause of the previous revert was a now-fixed GN race condition. TBR=xhwang@chromium.org Review-Url: https://codereview.chromium.org/2643333002 Cr-Commit-Position: refs/heads/master@{#445226} Committed: https://chromium.googlesource.com/chromium/src/+/68c7753dd291fbf573dc67c258284440f5aad6ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -137 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/cdm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/cdm/browser/cdm_message_filter_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cdm/common/widevine_drm_delegate_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/cdm/renderer/android_key_systems.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/cdm/renderer/external_clear_key_key_system_properties.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/cdm/renderer/widevine_key_system_properties.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_color_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/media_redirect_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/media/media_source_browsertest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M media/BUILD.gn View 3 chunks +20 lines, -25 lines 0 comments Download
M media/base/audio_video_metadata_extractor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/demuxer_perftest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/eme_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/key_systems.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M media/base/media_file_checker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/mime_util_internal.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M media/base/mime_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cdm/cdm_adapter_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/audio_decoder_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M media/filters/audio_file_reader_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_perftest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 12 chunks +13 lines, -12 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/widevine/cdm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
brettw
3 years, 11 months ago (2017-01-20 20:57:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643333002/1
3 years, 11 months ago (2017-01-20 20:58:31 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:28:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68c7753dd291fbf573dc67c25828...

Powered by Google App Engine
This is Rietveld 408576698