Issue 264333011: Oilpan: Prepare to move Element subclasses in TextControlInnerEelments to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264333011: Oilpan: Prepare to move Element subclasses in TextControlInnerEelments to Oilpan heap. (Closed)

Created:
6 years, 7 months ago by tkent

Modified:
6 years, 7 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Prepare to move Element subclasses in TextControlInnerEelments to Oilpan heap. This CL handles the followings: - TextControlInnerContainer - EditingViewPortElement - TextControlInnerTextElement - SearchFieldDecorationElement - SearchFieldCancelButtonElement Also, add 'explicit' to their constructors. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173596

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -26 lines)			Patch
M	Source/core/html/forms/TextFieldInputType.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/html/shadow/TextControlInnerElements.h	View	3 chunks	+11 lines, -10 lines	0 comments	Download
M	Source/core/html/shadow/TextControlInnerElements.cpp	View	5 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/264333011/1

6 years, 7 months ago (2014-05-08 02:43:48 UTC) #4

Message was sent while issue was closed.

Change committed as 173596

Expand Messages | Collapse Messages