Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 264333011: Oilpan: Prepare to move Element subclasses in TextControlInnerEelments to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/shadow/TextControlInnerElements.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/TextFieldInputType.cpp
diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp
index 5d8e19ce911ba504ddecf3292b7bca5ab25f895e..2981be7d6541ffc18cdd0d5a8f1f3f006b22649c 100644
--- a/Source/core/html/forms/TextFieldInputType.cpp
+++ b/Source/core/html/forms/TextFieldInputType.cpp
@@ -287,17 +287,17 @@ void TextFieldInputType::createShadowSubtree()
bool shouldHaveDataListIndicator = element().hasValidDataListOptions();
bool createsContainer = shouldHaveSpinButton || shouldHaveDataListIndicator || needsContainer();
- RefPtr<TextControlInnerTextElement> innerEditor = TextControlInnerTextElement::create(document);
+ RefPtrWillBeRawPtr<TextControlInnerTextElement> innerEditor = TextControlInnerTextElement::create(document);
if (!createsContainer) {
shadowRoot->appendChild(innerEditor.release());
return;
}
- RefPtr<TextControlInnerContainer> container = TextControlInnerContainer::create(document);
+ RefPtrWillBeRawPtr<TextControlInnerContainer> container = TextControlInnerContainer::create(document);
container->setShadowPseudoId(AtomicString("-webkit-textfield-decoration-container", AtomicString::ConstructFromLiteral));
shadowRoot->appendChild(container);
- RefPtr<EditingViewPortElement> editingViewPort = EditingViewPortElement::create(document);
+ RefPtrWillBeRawPtr<EditingViewPortElement> editingViewPort = EditingViewPortElement::create(document);
editingViewPort->appendChild(innerEditor.release());
container->appendChild(editingViewPort.release());
@@ -339,11 +339,11 @@ void TextFieldInputType::listAttributeTargetChanged()
// FIXME: The following code is similar to createShadowSubtree(),
// but they are different. We should simplify the code by making
// containerElement mandatory.
- RefPtr<Element> rpContainer = TextControlInnerContainer::create(document);
+ RefPtrWillBeRawPtr<Element> rpContainer = TextControlInnerContainer::create(document);
rpContainer->setShadowPseudoId(AtomicString("-webkit-textfield-decoration-container", AtomicString::ConstructFromLiteral));
- RefPtr<Element> innerEditor = element().innerTextElement();
+ RefPtrWillBeRawPtr<Element> innerEditor = element().innerTextElement();
innerEditor->parentNode()->replaceChild(rpContainer.get(), innerEditor.get());
- RefPtr<Element> editingViewPort = EditingViewPortElement::create(document);
+ RefPtrWillBeRawPtr<Element> editingViewPort = EditingViewPortElement::create(document);
editingViewPort->appendChild(innerEditor.release());
rpContainer->appendChild(editingViewPort.release());
rpContainer->appendChild(DataListIndicatorElement::create(document));
« no previous file with comments | « no previous file | Source/core/html/shadow/TextControlInnerElements.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698