Issue 264333002: Revert 172810 "Add a "forwarded" flag to usergesture tokens."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264333002: Revert 172810 "Add a "forwarded" flag to usergesture tokens." (Closed)

Created:
6 years, 7 months ago by Marijn Kruisselbrink

Modified:
6 years, 7 months ago

Reviewers:
Marijn Kruisselbrink

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 172810 "Add a "forwarded" flag to usergesture tokens." This had the unintended side effect of breaking websites, so reverting this while we figure out a proper fix. BUG=369963 > Add a "forwarded" flag to usergesture tokens. > > Exposing this and using it in DOMTimer to check if a user gesture token > should be forwarded allows for other ways of forwarding user gestures > while still preventing a user gesture from being forwarded more than > once. > > BUG=354217 > > Review URL: https://codereview.chromium.org/258783004 TBR=mek@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173445

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -92 lines)			Patch
D	trunk/LayoutTests/fast/events/popup-forwarded-postmessage-blocked.html	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/LayoutTests/fast/events/popup-forwarded-postmessage-blocked-expected.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/Source/core/frame/DOMTimer.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	trunk/Source/core/frame/DOMWindow.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/Source/platform/UserGestureIndicator.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/platform/UserGestureIndicator.cpp	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	trunk/Source/web/WebUserGestureToken.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/Source/web/tests/WebUserGestureTokenTest.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/public/web/WebUserGestureToken.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r173445.

Expand Messages | Collapse Messages