Add a "forwarded" flag to usergesture tokens.

Add a "forwarded" flag to usergesture tokens.

Exposing this and using it in DOMTimer to check if a user gesture token
should be forwarded allows for other ways of forwarding user gestures
while still preventing a user gesture from being forwarded more than
once.

BUG=354217
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172810

[Marijn Kruisselbrink, 2014-04-25 21:40:11]

This implements what you suggested in https://codereview.chromium.org/239503008/
Instead of passing along the timeout this just generally limits forwarding of
user gestures to be only allowed once (and exposes the "forwarded" flag so the
extensions code in https://codereview.chromium.org/256623008/ can set it).

This also actually fixes what I think is a bug in blink. Similar to the
extensions messaging system, window.postMessage sometimes also forwards a user
gesture, which defeats the old nested timer check (see the new layout test,
without my other changes that layout test would actually fail). Maybe this also
means that postMessage should set this new forwarded flag? Right now it is still
possible for a page to indefinitely hold on to a user gesture by repeatedly
postMessage-ing it to itself.

[jochen (gone - plz use gerrit), 2014-04-28 09:27:16]

should DOMWindow::postMessageTimerFired also mark the token as forwarded?

lgtm, nice catch anyway

[Marijn Kruisselbrink, 2014-04-28 18:10:10]

On 2014/04/28 09:27:16, jochen wrote:
> should DOMWindow::postMessageTimerFired also mark the token as forwarded?
Yes, that's what I meant with my question if postMessage should set the
forwarded flag. I've done so now.

[Marijn Kruisselbrink, 2014-04-28 19:47:05]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-04-28 19:47:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/258783004/100001

[commit-bot: I haz the power, 2014-04-28 20:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:47:23]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[Marijn Kruisselbrink, 2014-04-28 20:49:55]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:50:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/258783004/100001

[commit-bot: I haz the power, 2014-04-28 22:20:09]

Change committed as 172810