Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2643273002: Grab system and process memory stats into crash keys in fallback handler. (Closed)

Created:
3 years, 11 months ago by Sigurður Ásgeirsson
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Grab system and process memory stats into crash keys in fallback handler. R=scottmg@chromium.org BUG=683158 Review-Url: https://codereview.chromium.org/2643273002 Cr-Commit-Position: refs/heads/master@{#445079} Committed: https://chromium.googlesource.com/chromium/src/+/f623c0b50e5dec7eafdfc5699412ea60548471a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M components/crash/content/app/fallback_crash_handler_win.cc View 4 chunks +40 lines, -2 lines 0 comments Download
M components/crash/content/app/fallback_crash_handler_win_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Sigurður Ásgeirsson
Hey Scott, it'd be great if you can bless this one today - or otherwise ...
3 years, 11 months ago (2017-01-20 15:36:20 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-20 16:54:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643273002/1
3 years, 11 months ago (2017-01-20 16:56:34 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 17:00:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f623c0b50e5dec7eafdfc5699412...

Powered by Google App Engine
This is Rietveld 408576698