Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2643193002: Deflake virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake virtual/gpu/fast/canvas/canvas-lose-restore-max-int-size.html This patch rewrites fast/canvas/canvas-lose-restore-max-int-size.html to use testharness.js and avoid random deviations in the test output from causing the test to fail flakily. New test output: This is a testharness.js-based test. PASS Context should initially not be lost PASS Context should be lost when size is set to an extremely large number and then restored when set to a reasonable number PASS contextlost event should fire after size is set to extremely large number PASS contextrestored event should fire after size is restored to a reasonable number Harness: the test ran to completion. BUG=682964 Review-Url: https://codereview.chromium.org/2643193002 Cr-Commit-Position: refs/heads/master@{#448127} Committed: https://chromium.googlesource.com/chromium/src/+/a67e9c930f58bb30971795c3da424dfe3bf00906

Patch Set 1 #

Patch Set 2 : Remove test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -86 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-max-int-size.html View 1 chunk +45 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-max-int-size-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-20 06:00:20 UTC) #2
Justin Novosad
Nice! lgtm
3 years, 11 months ago (2017-01-24 14:14:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643193002/1
3 years, 11 months ago (2017-01-25 03:48:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/377678)
3 years, 11 months ago (2017-01-25 04:50:46 UTC) #7
alancutter (OOO until 2018)
On 2017/01/25 at 04:50:46, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng ...
3 years, 10 months ago (2017-02-03 23:17:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643193002/20001
3 years, 10 months ago (2017-02-03 23:20:16 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 00:48:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a67e9c930f58bb30971795c3da42...

Powered by Google App Engine
This is Rietveld 408576698