Issue 2643163004: Use ICCProfile to construct SkColorSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2643163004: Use ICCProfile to construct SkColorSpace (Closed)

Created:
3 years, 11 months ago by ccameron

Modified:
3 years, 11 months ago

Reviewers:
esprehn

CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, cc-bugs_chromium.org, ajuma+watch_chromium.org, kinuko+watch, rwlbuis

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use ICCProfile to construct SkColorSpace This is a re-landing of parts of https://codereview.chromium.org/2605743002/ To determine the reason for trybots not matching continuous bots. This time, ensure that the space's profile is not communicated through the TileManager. TBR=esprehn BUG=634102 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	cc/tiles/tile_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

3 years, 11 months ago (2017-01-21 05:02:48 UTC) #3

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages