Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2643163002:
Refactor print_job.cc (Closed)
|
Created:
3 years, 11 months ago by rbpotter Modified:
3 years, 11 months ago Reviewers:
Vitaly Buka (NO REVIEWS) CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor print_job.cc
Refactor sections of PrintJob to facilitate addition of postscript
printing code (see https://codereview.chromium.org/2633573002/)
BUG=None
Review-Url: https://codereview.chromium.org/2643163002
Cr-Commit-Position: refs/heads/master@{#445204}
Committed: https://chromium.googlesource.com/chromium/src/+/ca879edd87d5753d095a5dcecf74d2176fbabd1c
Patch Set 1 #Patch Set 2 : Add comment #
Total comments: 4
Patch Set 3 : Remove extra class and fix return vals #Patch Set 4 : Fix protected #
Total comments: 2
Patch Set 5 : Fix constructor #Messages
Total messages: 25 (18 generated)
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Description was changed from ========== Refactor print_job.cc Refactor sections of PrintJob to facilitate addition of postscript printing code (see https://codereview.chromium.org/2633573002/) BUG=None ========== to ========== Refactor print_job.cc Refactor sections of PrintJob to facilitate addition of postscript printing code (see https://codereview.chromium.org/2633573002/) BUG=None ==========
rbpotter@chromium.org changed reviewers: + vitalybuka@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2643163002/diff/20001/chrome/browser/printing... File chrome/browser/printing/print_job.cc (right): https://codereview.chromium.org/2643163002/diff/20001/chrome/browser/printing... chrome/browser/printing/print_job.cc:263: protected: I don't reason for exception here https://google.github.io/styleguide/cppguide.html#Access_Control https://codereview.chromium.org/2643163002/diff/20001/chrome/browser/printing... chrome/browser/printing/print_job.cc:275: page_size_ = page_size; Why not to just remove this class and use something like new PrintJob::PdfConversionState(size, area, PdfConverter::CreatePdfToEmfConverter())
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2643163002/diff/20001/chrome/browser/printing... File chrome/browser/printing/print_job.cc (right): https://codereview.chromium.org/2643163002/diff/20001/chrome/browser/printing... chrome/browser/printing/print_job.cc:263: protected: On 2017/01/20 08:36:47, Vitaly Buka wrote: > I don't reason for exception here > https://google.github.io/styleguide/cppguide.html#Access_Control Done. https://codereview.chromium.org/2643163002/diff/20001/chrome/browser/printing... chrome/browser/printing/print_job.cc:275: page_size_ = page_size; On 2017/01/20 08:36:47, Vitaly Buka wrote: > Why not to just remove this class and > use something like > new PrintJob::PdfConversionState(size, area, > PdfConverter::CreatePdfToEmfConverter()) > Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2643163002/diff/60001/chrome/browser/printing... File chrome/browser/printing/print_job.cc (right): https://codereview.chromium.org/2643163002/diff/60001/chrome/browser/printing... chrome/browser/printing/print_job.cc:235: converter_.reset(converter.release()); converter_(std::move(converter));
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
https://codereview.chromium.org/2643163002/diff/60001/chrome/browser/printing... File chrome/browser/printing/print_job.cc (right): https://codereview.chromium.org/2643163002/diff/60001/chrome/browser/printing... chrome/browser/printing/print_job.cc:235: converter_.reset(converter.release()); On 2017/01/20 19:18:22, Vitaly Buka wrote: > converter_(std::move(converter)); Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vitalybuka@chromium.org Link to the patchset: https://codereview.chromium.org/2643163002/#ps80001 (title: "Fix constructor")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484953752526260,
"parent_rev": "8397c08b01935f854e527ba42c9563ba852f1981", "commit_rev":
"ca879edd87d5753d095a5dcecf74d2176fbabd1c"}
Message was sent while issue was closed.
Description was changed from ========== Refactor print_job.cc Refactor sections of PrintJob to facilitate addition of postscript printing code (see https://codereview.chromium.org/2633573002/) BUG=None ========== to ========== Refactor print_job.cc Refactor sections of PrintJob to facilitate addition of postscript printing code (see https://codereview.chromium.org/2633573002/) BUG=None Review-Url: https://codereview.chromium.org/2643163002 Cr-Commit-Position: refs/heads/master@{#445204} Committed: https://chromium.googlesource.com/chromium/src/+/ca879edd87d5753d095a5dcecf74... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/ca879edd87d5753d095a5dcecf74... |
