Fetch the first tab inside the browser startup retry loop.

Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2643023004
Cr-Commit-Position: refs/heads/master@{#444930}
Committed: https://chromium.googlesource.com/chromium/src/+/63505a7684eeca1f5f49c553e677e91bdb0ec67a

[Ken Russell (switch to Gerrit), 2017-01-20 00:15:01]

Description was changed from

==========
Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
==========

to

==========
Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-01-20 00:16:36]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2017-01-20 00:16:37]

Mo: FYI. I'm CQ'ing this TBR'd because I've tested it locally and think it will
address the flakiness seen on the waterfall. If it fails the tryjobs with these
flaky failures I'll reconsider the approach.

Others: FYI.

[Ken Russell (switch to Gerrit), 2017-01-20 00:16:46]

Description was changed from

==========
Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

[Ken Russell (switch to Gerrit), 2017-01-20 00:17:26]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-01-20 00:18:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:42:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484871446849850, "parent_rev":
"f2a640e932be7a9765472c6d6e8f90f9b2a02970", "commit_rev":
"63505a7684eeca1f5f49c553e677e91bdb0ec67a"}

[commit-bot: I haz the power, 2017-01-20 01:42:43]

Description was changed from

==========
Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

to

==========
Fetch the first tab inside the browser startup retry loop.

This is the operation which is timing out. Attempt a retry to see if
it can be made to work reliably.

This changes the behavior of the unit tests. Removed a forced crash
from testSimpleIntegrationUnittest because it was interfering with the
execution of some of the other tests. A TODO has been added about
better simulating the kinds of errors being seen on the waterfall; a
new test needs to be written to cover all of the new code paths. Also
removed bogus expectations from testIntegrationUnittestWithBrowserFailure.

BUG=682819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2643023004
Cr-Commit-Position: refs/heads/master@{#444930}
Committed:
https://chromium.googlesource.com/chromium/src/+/63505a7684eeca1f5f49c553e677...
==========

[commit-bot: I haz the power, 2017-01-20 01:42:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/63505a7684eeca1f5f49c553e677...