Add data usage tracking for chrome services

Add data usage tracking for chrome services

Add data usage tracking for captive portal, web resource and signin services

BUG=655749
Review-Url: https://codereview.chromium.org/2643013004
Cr-Commit-Position: refs/heads/master@{#445810}
Committed: https://chromium.googlesource.com/chromium/src/+/a81c185f34b34ef8410239506825b185b332c00b

[Raj, 2017-01-20 07:27:16]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 07:27:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 07:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 07:31:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Raj, 2017-01-20 18:00:41]

rajendrant@chromium.org changed reviewers:
+ achuith@chromium.org, mmenke@chromium.org, rkaplow@chromium.org,
rogerta@chromium.org

[Raj, 2017-01-20 18:00:41]

achuith: ptal components/web_resource/*

mmenke: ptal components/captive_portal/*

rogerta: ptal components/signin/core/browser/*

rkaplow: ptal histograms.xml

[mmenke, 2017-01-20 18:12:13]

On 2017/01/20 18:00:41, Raj wrote:
> achuith: ptal components/web_resource/*
> 
> mmenke: ptal components/captive_portal/*
> 
> rogerta: ptal components/signin/core/browser/*
> 
> rkaplow: ptal histograms.xml

captive_portal LGTM

[Raj, 2017-01-20 20:04:40]

rajendrant@chromium.org changed reviewers:
+ tbansal@chromium.org

[Raj, 2017-01-20 20:04:41]

tbansal: ptal components/data_use_measurement/core/*

[rkaplow, 2017-01-20 22:42:47]

https://codereview.chromium.org/2643013004/diff/20001/components/data_use_mea...
File components/data_use_measurement/core/data_use_user_data.cc (right):

https://codereview.chromium.org/2643013004/diff/20001/components/data_use_mea...
components/data_use_measurement/core/data_use_user_data.cc:108: return SIGNIN;
why is this not returning a string?

[tbansal1, 2017-01-20 23:10:16]

lgtm

[Raj, 2017-01-20 23:28:11]

Fixed comments.

https://codereview.chromium.org/2643013004/diff/20001/components/data_use_mea...
File components/data_use_measurement/core/data_use_user_data.cc (right):

https://codereview.chromium.org/2643013004/diff/20001/components/data_use_mea...
components/data_use_measurement/core/data_use_user_data.cc:108: return SIGNIN;
On 2017/01/20 22:42:47, rkaplow wrote:
> why is this not returning a string?

Oops. Fixed.

[Raj, 2017-01-21 21:40:45]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 21:40:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 22:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 22:52:44]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-01-23 15:28:00]

lgtm

[Roger Tawa OOO till Jul 10th, 2017-01-23 15:44:34]

rogerta@chromium.org changed reviewers:
+ msarda@chromium.org

[Roger Tawa OOO till Jul 10th, 2017-01-23 15:44:36]

lgtm for signin deps, but since I don't work on signin anymore adding Mihai who
is new signin onwer.

[msarda, 2017-01-23 16:40:04]

LGTM for sign-in code.

[Raj, 2017-01-23 18:02:55]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2017-01-23 18:02:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2643013004/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-23 18:03:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 18:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:11:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[achuithb, 2017-01-24 19:40:27]

lgtm

[Raj, 2017-01-24 19:43:02]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2017-01-24 19:43:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, rkaplow@chromium.org, achuith@chromium.org,
tbansal@chromium.org, mmenke@chromium.org, msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2643013004/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-24 19:43:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 21:13:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485286982327550,
"parent_rev": "2bceda4948deeaed0a5a99305d0d488eb952f64f", "commit_rev":
"a81c185f34b34ef8410239506825b185b332c00b"}

[commit-bot: I haz the power, 2017-01-24 21:14:18]

Description was changed from

==========
Add data usage tracking for chrome services

Add data usage tracking for captive portal, web resource and signin services

BUG=655749
==========

to

==========
Add data usage tracking for chrome services

Add data usage tracking for captive portal, web resource and signin services

BUG=655749

Review-Url: https://codereview.chromium.org/2643013004
Cr-Commit-Position: refs/heads/master@{#445810}
Committed:
https://chromium.googlesource.com/chromium/src/+/a81c185f34b34ef8410239506825...
==========

[commit-bot: I haz the power, 2017-01-24 21:14:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a81c185f34b34ef8410239506825...