Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2642923005: Migrate Timer to TaskRunnerTimer in ScreenOrientationControllerImpl (Closed)

Created:
3 years, 11 months ago by Hwanseung Lee
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate Timer to TaskRunnerTimer in ScreenOrientationControllerImpl Spec that defines : [1]https://w3c.github.io/screen-orientation/#screenorientation-interface BUG=624694 Review-Url: https://codereview.chromium.org/2642923005 Cr-Commit-Position: refs/heads/master@{#445856} Committed: https://chromium.googlesource.com/chromium/src/+/a524dbf5bad0e4c8b479bb0b2915afed6d240d3d

Patch Set 1 #

Patch Set 2 : Migrate Timer to TaskRunnerTimer in ScreenOrientationControllerImpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Hwanseung Lee
@haraken PTAL, thank you.
3 years, 11 months ago (2017-01-20 15:11:52 UTC) #4
haraken
Per the spec, it looks like that the task source for the onchange event is ...
3 years, 11 months ago (2017-01-20 16:13:24 UTC) #6
Hwanseung Lee
On 2017/01/20 16:13:24, haraken wrote: > Per the spec, it looks like that the task ...
3 years, 11 months ago (2017-01-21 14:48:03 UTC) #14
mlamouri (slow - plz ping)
haraken@, my understanding of the specification is that we should fire the change event in ...
3 years, 11 months ago (2017-01-23 00:10:04 UTC) #15
Hwanseung Lee
On 2017/01/23 00:10:04, mlamouri wrote: > haraken@, my understanding of the specification is that we ...
3 years, 11 months ago (2017-01-24 12:05:37 UTC) #17
foolip
On 2017/01/24 12:05:37, Hwanseung Lee wrote: > On 2017/01/23 00:10:04, mlamouri wrote: > > haraken@, ...
3 years, 11 months ago (2017-01-24 12:35:10 UTC) #18
haraken
LGTM
3 years, 11 months ago (2017-01-24 21:09:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642923005/20001
3 years, 11 months ago (2017-01-24 21:17:49 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 23:28:20 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a524dbf5bad0e4c8b479bb0b2915...

Powered by Google App Engine
This is Rietveld 408576698