Removing Scroll user actions because they are extremely spammy.

Removing *Scroll user actions because they are extremely spammy.

Specifically TouchscreenScroll and TrackpadScroll

BUG=682329
Review-Url: https://codereview.chromium.org/2642903002
Cr-Commit-Position: refs/heads/master@{#444862}
Committed: https://chromium.googlesource.com/chromium/src/+/bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d

[jwd, 2017-01-18 18:40:35]

Description was changed from

==========
Removing *Scroll user actions because they are extremely spammy.

BUG=
==========

to

==========
Removing *Scroll user actions because they are extremely spammy.

Specifically TouchscreenScroll and TrackpadScroll

BUG=682329
==========

[jwd, 2017-01-18 18:40:35]

jwd@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2017-01-18 19:07:11]

https://codereview.chromium.org/2642903002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_event_handler.cc
(left):

https://codereview.chromium.org/2642903002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_event_handler.cc:530:
RecordAction(base::UserMetricsAction("TouchscreenScroll"));
Perhaps we should still call this, but only on scroll begin?

[jwd, 2017-01-18 19:23:47]

https://codereview.chromium.org/2642903002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_event_handler.cc
(left):

https://codereview.chromium.org/2642903002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_event_handler.cc:530:
RecordAction(base::UserMetricsAction("TouchscreenScroll"));
On 2017/01/18 19:07:11, tdresser wrote:
> Perhaps we should still call this, but only on scroll begin?

Done.

And clearly I wasn't paying much attention to the code I was changing :S

[tdresser, 2017-01-18 19:32:06]

LGTM.

+sahel, since once we have touchpad latching, we could re-add this for touchpad,
and only report once per touchpad scroll.

Sahel, can you file a bug to add this back once touchpad latching is done?

[Alexei Svitkine (slow), 2017-01-18 19:34:41]

drive-by: if we're keeping some of these metrics, can they be given owners
in actions.xml?

On Wed, Jan 18, 2017 at 2:32 PM, <tdresser@chromium.org> wrote:

> LGTM.
>
> +sahel, since once we have touchpad latching, we could re-add this for
> touchpad,
> and only report once per touchpad scroll.
>
> Sahel, can you file a bug to add this back once touchpad latching is done?
>
> https://codereview.chromium.org/2642903002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tdresser, 2017-01-18 19:36:36]

Feel free to mark me as owner.

On 2017/01/18 19:34:41, Alexei Svitkine (slow) wrote:
> drive-by: if we're keeping some of these metrics, can they be given owners
> in actions.xml?
> 
> On Wed, Jan 18, 2017 at 2:32 PM, <mailto:tdresser@chromium.org> wrote:
> 
> > LGTM.
> >
> > +sahel, since once we have touchpad latching, we could re-add this for
> > touchpad,
> > and only report once per touchpad scroll.
> >
> > Sahel, can you file a bug to add this back once touchpad latching is done?
> >
> > https://codereview.chromium.org/2642903002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[jwd, 2017-01-18 19:36:42]

On 2017/01/18 19:34:41, Alexei Svitkine (slow) wrote:
> drive-by: if we're keeping some of these metrics, can they be given owners
> in actions.xml?
> 
> On Wed, Jan 18, 2017 at 2:32 PM, <mailto:tdresser@chromium.org> wrote:
> 
> > LGTM.
> >
> > +sahel, since once we have touchpad latching, we could re-add this for
> > touchpad,
> > and only report once per touchpad scroll.
> >
> > Sahel, can you file a bug to add this back once touchpad latching is done?
> >
> > https://codereview.chromium.org/2642903002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

tdresser, Sahel, do either of you want to be the owner, or do you know who
should be?

[jwd, 2017-01-18 20:03:40]

The CQ bit was checked by jwd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 20:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 20:58:22]

Dry run: This issue passed the CQ dry run.

[jwd, 2017-01-19 21:25:26]

Added tdresser as owner of those actions.

[jwd, 2017-01-19 21:25:29]

The CQ bit was checked by jwd@chromium.org

[jwd, 2017-01-19 21:25:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2642903002/#ps60001
(title: "Adding action owners")

[commit-bot: I haz the power, 2017-01-19 21:25:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:22:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484861129963890,
"parent_rev": "8faae2abff3afc7c7a0a781d7135bf128cfc718b", "commit_rev":
"bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d"}

[commit-bot: I haz the power, 2017-01-19 22:22:52]

Description was changed from

==========
Removing *Scroll user actions because they are extremely spammy.

Specifically TouchscreenScroll and TrackpadScroll

BUG=682329
==========

to

==========
Removing *Scroll user actions because they are extremely spammy.

Specifically TouchscreenScroll and TrackpadScroll

BUG=682329

Review-Url: https://codereview.chromium.org/2642903002
Cr-Commit-Position: refs/heads/master@{#444862}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb1aaf95ea8fd6a5815d512a690a...
==========

[commit-bot: I haz the power, 2017-01-19 22:22:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bb1aaf95ea8fd6a5815d512a690a...