Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 2642893002: Adjust positioning of location bar icons. (Closed)
Patch Set: nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 70d593888d625e780404aa1ea27849b7a89d14ea..3b8fd6112c2076ba37f677290a0deaa86d43ac39 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -108,12 +108,13 @@ class LocationBarView : public LocationBar,
SECURITY_CHIP_TEXT,
};
- // Width (and height) of icons in location bar.
+ // Visual width (and height) of icons in location bar.
static constexpr int kIconWidth = 16;
- // Space between items in the location bar, as well as between items and the
- // edges.
- static constexpr int kHorizontalPadding = 6;
+ // The amount of padding between the visual edge of an icon and the edge of
+ // its click target, for all all sides of the icon. The total edge length of
+ // each icon view should be kIconWidth + 2 * kIconInteriorPadding.
+ static constexpr int kIconInteriorPadding = 4;
// The additional vertical padding of a bubble.
static constexpr int kBubbleVerticalPadding = 3;
« no previous file with comments | « chrome/browser/ui/views/location_bar/keyword_hint_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698