Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 2642893002: Adjust positioning of location bar icons. (Closed)
Patch Set: nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 }; 101 };
102 102
103 enum ColorKind { 103 enum ColorKind {
104 BACKGROUND = 0, 104 BACKGROUND = 0,
105 TEXT, 105 TEXT,
106 SELECTED_TEXT, 106 SELECTED_TEXT,
107 DEEMPHASIZED_TEXT, 107 DEEMPHASIZED_TEXT,
108 SECURITY_CHIP_TEXT, 108 SECURITY_CHIP_TEXT,
109 }; 109 };
110 110
111 // Width (and height) of icons in location bar. 111 // Visual width (and height) of icons in location bar.
112 static constexpr int kIconWidth = 16; 112 static constexpr int kIconWidth = 16;
113 113
114 // Space between items in the location bar, as well as between items and the 114 // The amount of padding between the visual edge of an icon and the edge of
115 // edges. 115 // its click target, for all all sides of the icon. The total edge length of
116 static constexpr int kHorizontalPadding = 6; 116 // each icon view should be kIconWidth + 2 * kIconInteriorPadding.
117 static constexpr int kIconInteriorPadding = 4;
117 118
118 // The additional vertical padding of a bubble. 119 // The additional vertical padding of a bubble.
119 static constexpr int kBubbleVerticalPadding = 3; 120 static constexpr int kBubbleVerticalPadding = 3;
120 121
121 // The location bar view's class name. 122 // The location bar view's class name.
122 static const char kViewClassName[]; 123 static const char kViewClassName[];
123 124
124 LocationBarView(Browser* browser, 125 LocationBarView(Browser* browser,
125 Profile* profile, 126 Profile* profile,
126 CommandUpdater* command_updater, 127 CommandUpdater* command_updater,
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 BooleanPrefMember edit_bookmarks_enabled_; 471 BooleanPrefMember edit_bookmarks_enabled_;
471 472
472 // This is a debug state variable that stores if the WebContents was null 473 // This is a debug state variable that stores if the WebContents was null
473 // during the last RefreshPageAction. 474 // during the last RefreshPageAction.
474 bool web_contents_null_at_last_refresh_; 475 bool web_contents_null_at_last_refresh_;
475 476
476 DISALLOW_COPY_AND_ASSIGN(LocationBarView); 477 DISALLOW_COPY_AND_ASSIGN(LocationBarView);
477 }; 478 };
478 479
479 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 480 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/keyword_hint_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698