Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2642843002: Revert of [Ignition/turbo] Add a CallWithSpread bytecode. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Ignition/turbo] Add a CallWithSpread bytecode. (patchset #10 id:170001 of https://codereview.chromium.org/2629363002/ ) Reason for revert: Causes a few bugs caught by clusterfuzz. Original issue's description: > [Ignition/turbo] Add a CallWithSpread bytecode. > > Also, emit a NewWithSpread bytecode for CallNew AST nodes where possible, rather than desugaring in the parser. > > BUG=v8:5511 > > Review-Url: https://codereview.chromium.org/2629363002 > Cr-Commit-Position: refs/heads/master@{#42455} > Committed: https://chromium.googlesource.com/v8/v8/+/4bae43471d5685e34d8bd74458889b83e60235a0 TBR=bmeurer@chromium.org,rmcilroy@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5511 Review-Url: https://codereview.chromium.org/2642843002 Cr-Commit-Position: refs/heads/master@{#42470} Committed: https://chromium.googlesource.com/v8/v8/+/75b861210f20ae00972125d21eed1ac234ba2825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -521 lines) Patch
M src/ast/ast.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 6 chunks +12 lines, -45 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -21 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 2 chunks +70 lines, -69 lines 0 comments Download
M src/parsing/parser-base.h View 4 chunks +2 lines, -8 lines 0 comments Download
M src/parsing/preparser.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D test/cctest/interpreter/bytecode_expectations/CallAndSpread.golden View 1 chunk +0 lines, -107 lines 0 comments Download
D test/cctest/interpreter/bytecode_expectations/NewAndSpread.golden View 1 chunk +0 lines, -157 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
petermarshall
Created Revert of [Ignition/turbo] Add a CallWithSpread bytecode.
3 years, 11 months ago (2017-01-18 17:03:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642843002/1
3 years, 11 months ago (2017-01-18 17:03:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-18 17:03:40 UTC) #5
Franzi
lgtm
3 years, 11 months ago (2017-01-18 17:05:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642843002/1
3 years, 11 months ago (2017-01-18 17:06:08 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 17:06:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/75b861210f20ae00972125d21eed1ac234b...

Powered by Google App Engine
This is Rietveld 408576698